Skip to content

Add more test cases for Generator#1216

Merged
k8s-ci-robot merged 6 commits into
kubeflow:masterfrom
andreyvelich:generator-add-tests
Jun 16, 2020
Merged

Add more test cases for Generator#1216
k8s-ci-robot merged 6 commits into
kubeflow:masterfrom
andreyvelich:generator-add-tests

Conversation

@andreyvelich

@andreyvelich andreyvelich commented Jun 15, 2020

Copy link
Copy Markdown
Member

I added more unit test cases for Generator.
Part of: #1208.

/assign @johnugeorge @gaocegege

@kubeflow-bot

Copy link
Copy Markdown

This change is Reviewable

@gaocegege gaocegege left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0be190a into kubeflow:master Jun 16, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
* Init commit

* Add test to generator for unstructured

* Add test to generator for configmap

* Fix log

* Add comment
@andreyvelich andreyvelich deleted the generator-add-tests branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants