Skip to content

Update ThemeAwareFormGroupWrapper usage and imports#2806

Open
Philip-Carneiro wants to merge 1 commit into
kubeflow:mainfrom
Philip-Carneiro:refactor/theme-aware-form-group-wrapper-migration
Open

Update ThemeAwareFormGroupWrapper usage and imports#2806
Philip-Carneiro wants to merge 1 commit into
kubeflow:mainfrom
Philip-Carneiro:refactor/theme-aware-form-group-wrapper-migration

Conversation

@Philip-Carneiro

Copy link
Copy Markdown
Contributor

Description

Update the imports and usage of the ThemeAwareFormGroupWrapper

How Has This Been Tested?

It was manually tested and used the existent e2e tests, no tests added.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow google-oss-prow Bot requested review from chambridge and fege June 8, 2026 15:48
@Philip-Carneiro Philip-Carneiro force-pushed the refactor/theme-aware-form-group-wrapper-migration branch from 5a76daf to 87fd62c Compare June 10, 2026 09:31
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro Philip-Carneiro force-pushed the refactor/theme-aware-form-group-wrapper-migration branch from 87fd62c to b66b4ea Compare June 16, 2026 10:26
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lucferbux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant