Process to adopt paddle/operator

[Bobgy]

Because we accepted #502 paddle operator proposal.

Now we can start the process to adopt the external repo.

[Bobgy]

/cc @kubeflow/wg-training-leads @tizhou86

[Bobgy]

Plan:

1. Stage current https://github.com/PaddleFlow/paddle-operator repo into google internal git.
2. Google internal release process (there might be back and forths on repo requirements, I'll sync with @tizhou86 to resolve them).
3. Once the kubeflow/paddle-opeartor repo is public, I can add OWNERS for @tizhou86, @kuizhiqing and @kubeflow/wg-training-leads.
4. Push new commits to the repo during the process.
5. Archive the existing repo.

Note, I cannot rename the existing github repo directly due to policy issues, so issue transfer etc is not possible. Luckily, we don't have many issues yet: https://github.com/PaddleFlow/paddle-operator/issues

[Bobgy]

That's my rough plan. Any concerns?

[Bobgy]

For license requirement

@tizhou86 May I confirm, is all the code in https://github.com/PaddleFlow/paddle-operator currently wrote by your company? Are there snippets or files copied from other projects?

If you have copied snippets, it's not a big problem, but you'll need to move them into a "third_party" folder at the root of the repo and mention original copyright and license, example: https://github.com/kubeflow/pipelines/tree/master/third_party.

[Bobgy]

The copyright headers do not reference a company name. @tizhou86 do you want to update?
example:

https://github.com/PaddleFlow/paddle-operator/blob/0f1bab781dcd45059fd3e336a3aa7ecab9eaf601/controllers/paddlejob_controller.go#L2

Also can you add license headers for all the files (including yaml)?
You may use https://github.com/google/addlicense to add licenses easily.

[Bobgy]

For new open source projects, we will be enforcing inclusive language policies.
I found that there are several occurrences of "master" in the repo: https://github.com/PaddleFlow/paddle-operator/search?q=master.

reference:

• https://developers.google.com/style/word-list#master
• https://developers.google.com/style/inclusive-documentation

Can you investigate whether it's possible to avoid using "master" in code and API?

[Bobgy]

These are problems I found for the initial pass.

[tizhou86]

Hi Bobgy, I'll talk to some of our team members and resolve all the problems you mentioned asap, thanks!

[tizhou86]

/cc @kuizhiqing

[tizhou86]

Hi @Bobgy , All mentioned problems above are resolved in PRs: PaddleFlow/paddle-operator#48 and PaddleFlow/paddle-operator#49 , please let us know if anything is needed from our side, thanks!

[Bobgy]

@tizhou86 thanks!
LGTM except some minor problems:

• See two comments in Add license header for paddle operator. PaddleFlow/paddle-operator#49
• Can you also add copyright headers for yaml files https://github.com/PaddleFlow/paddle-operator/blob/main/deploy/v1/operator.yaml?

[Bobgy]

Another Q: did anyone file any patents around paddle-operator?

[kuizhiqing]

Hi @Bobgy , No, no patent is filed for paddle-operator now.