Adds kfserving ingressgateway for Istio 1.1.6 #949
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: kfserving-ingressgateway | ||
| labels: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| annotations: | ||
| sidecar.istio.io/inject: "false" | ||
| spec: | ||
| serviceAccountName: istio-ingressgateway-service-account | ||
| containers: | ||
| - name: istio-proxy | ||
| image: "docker.io/istio/proxyv2:1.1.6" | ||
| imagePullPolicy: IfNotPresent | ||
| ports: | ||
| - containerPort: 15020 | ||
| - containerPort: 80 | ||
| - containerPort: 443 | ||
| - containerPort: 31400 | ||
| - containerPort: 15029 | ||
| - containerPort: 15030 | ||
| - containerPort: 15031 | ||
| - containerPort: 15032 | ||
| - containerPort: 15443 | ||
| - containerPort: 15090 | ||
| protocol: TCP | ||
| name: http-envoy-prom | ||
| args: | ||
| - proxy | ||
| - router | ||
| - --domain | ||
| - $(POD_NAMESPACE).svc.cluster.local | ||
| - --log_output_level=default:info | ||
| - --drainDuration | ||
| - '45s' #drainDuration | ||
| - --parentShutdownDuration | ||
| - '1m0s' #parentShutdownDuration | ||
| - --connectTimeout | ||
| - '10s' #connectTimeout | ||
| - --serviceCluster | ||
| - kfserving-ingressgateway | ||
| - --zipkinAddress | ||
| - zipkin:9411 | ||
| - --proxyAdminPort | ||
| - "15000" | ||
| - --statusPort | ||
| - "15020" | ||
| - --controlPlaneAuthPolicy | ||
| - NONE | ||
| - --discoveryAddress | ||
| - istio-pilot:15010 | ||
| readinessProbe: | ||
| failureThreshold: 30 | ||
| httpGet: | ||
| path: /healthz/ready | ||
| port: 15020 | ||
| scheme: HTTP | ||
| initialDelaySeconds: 1 | ||
| periodSeconds: 2 | ||
| successThreshold: 1 | ||
| timeoutSeconds: 1 | ||
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 10m | ||
| memory: 40Mi | ||
|
|
||
| env: | ||
| - name: POD_NAME | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: metadata.name | ||
| - name: POD_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: metadata.namespace | ||
| - name: INSTANCE_IP | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: status.podIP | ||
| - name: HOST_IP | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: status.hostIP | ||
| - name: ISTIO_META_POD_NAME | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: metadata.name | ||
| - name: ISTIO_META_CONFIG_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
| - name: ISTIO_META_ROUTER_MODE | ||
| value: sni-dnat | ||
| volumeMounts: | ||
| - name: istio-certs | ||
| mountPath: /etc/certs | ||
| readOnly: true | ||
| - name: ingressgateway-certs | ||
| mountPath: "/etc/istio/ingressgateway-certs" | ||
| readOnly: true | ||
| - name: ingressgateway-ca-certs | ||
| mountPath: "/etc/istio/ingressgateway-ca-certs" | ||
| readOnly: true | ||
| volumes: | ||
| - name: istio-certs | ||
| secret: | ||
| secretName: istio.istio-ingressgateway-service-account | ||
| optional: true | ||
| - name: ingressgateway-certs | ||
| secret: | ||
| secretName: "istio-ingressgateway-certs" | ||
| optional: true | ||
| - name: ingressgateway-ca-certs | ||
| secret: | ||
| secretName: "istio-ingressgateway-ca-certs" | ||
| optional: true | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: beta.kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - ppc64le | ||
| - s390x | ||
| preferredDuringSchedulingIgnoredDuringExecution: | ||
| - weight: 2 | ||
| preference: | ||
| matchExpressions: | ||
| - key: beta.kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - weight: 2 | ||
| preference: | ||
| matchExpressions: | ||
| - key: beta.kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - ppc64le | ||
| - weight: 2 | ||
| preference: | ||
| matchExpressions: | ||
| - key: beta.kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - s390x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| apiVersion: autoscaling/v2beta1 | ||
| kind: HorizontalPodAutoscaler | ||
| metadata: | ||
| labels: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| name: kfserving-ingressgateway | ||
| spec: | ||
| maxReplicas: 5 | ||
| metrics: | ||
| - resource: | ||
| name: cpu | ||
| targetAverageUtilization: 80 | ||
| type: Resource | ||
| minReplicas: 1 | ||
| scaleTargetRef: | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| name: kfserving-ingressgateway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: istio-system | ||
| resources: | ||
| - deployment.yaml | ||
| - horizontal-pod-autoscaler.yaml | ||
| - service.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: kfserving-ingressgateway | ||
| labels: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| spec: | ||
| type: LoadBalancer | ||
| selector: | ||
| app: kfserving-ingressgateway | ||
| kfserving: ingressgateway | ||
| ports: | ||
| - name: status-port | ||
| port: 15020 | ||
| targetPort: 15020 | ||
| - name: http2 | ||
| nodePort: 32380 | ||
| port: 80 | ||
| targetPort: 80 | ||
| - name: https | ||
| nodePort: 32390 | ||
| port: 443 | ||
| - name: tcp | ||
| nodePort: 32400 | ||
| port: 31400 | ||
| - name: tcp-pilot-grpc-tls | ||
| port: 15011 | ||
| targetPort: 15011 | ||
| - name: tcp-citadel-grpc-tls | ||
| port: 8060 | ||
| targetPort: 8060 | ||
| - name: tcp-dns-tls | ||
| port: 853 | ||
| targetPort: 853 | ||
| - name: https-kiali | ||
| port: 15029 | ||
| targetPort: 15029 | ||
| - name: http2-prometheus | ||
| port: 15030 | ||
| targetPort: 15030 | ||
| - name: http2-grafana | ||
| port: 15031 | ||
|
Contributor
There was a problem hiding this comment. are these ports for kiali/grafana/prometheus always constant? do we deploy them with kubeflow?
Contributor
Author
There was a problem hiding this comment. @animeshsingh yes they are associated with the deployment config and are constant. We do deploy these services with Istio in Kubeflow.
Contributor
There was a problem hiding this comment. Thaks - great to know. What's the total infra cost of these 3 services - believe a container each? Are any customized Kubeflow metrics configured to flow to them
Contributor
Author
There was a problem hiding this comment. @animeshsingh These require a container each. Prometheus, Graphana etc do come with the default istio install in Kubeflow. Kubeflow does report Prometheus metrics through various operators or services like tfjob-operator or profile-controller. Likewise, the gateway container istio-proxy also reports metrics. These ports in question are ports which the istio-proxy container exposes. The container istio-proxy is a part of the deployment servicing kfserving-gateway. These ports host https end-points for each of these services like Prometheus to poll these (gateway) services for metrics. |
||
| targetPort: 15031 | ||
| - name: https-tracing | ||
| port: 15032 | ||
| targetPort: 15032 | ||
| - name: tls | ||
| port: 15443 | ||
| targetPort: 15443 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks the kubeflow istio ingressgateway is using NodePort https://github.com/kubeflow/manifests/blob/master/istio/istio-install/base/istio-noauth.yaml#L14047
Would this work for on prem setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuzisun The reason for istio-ingressgateway being NodePort is because of Google's IAP needing it to be NodePort.
If an on-premise setup has some component to provision a LoadBalancer, then LoadBalancer will get its IP. If not, the NodePorts are still accessible though the IP field for LoadBalancer will be in state.
IMO, This should be acceptable. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are using this ingress gateway in GCP IAP setup, so that's ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In istio-ingressgateway for GCP IAP, the ingress gateway service is exposed to an Identity Aware Proxy (which has auth checking) by the NodePort and the intention is to disallow access through any other mechanism other than this proxy.
Since we don't want to have auth checks, LoadBalancer should be alright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks for the explanation! btw we also need to also add the HPA for this ingress gateway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion @yuzisun. I'll include the definition for HPA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuzisun I've included an HPA.