-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(hub): deploy model registry to user profile namespace instead of default #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
google-oss-prow
merged 6 commits into
kubeflow:master
from
Raakshass:fix/hub-default-namespace
May 25, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8165480
fix(hub): deploy model registry to user profile namespace instead of …
Raakshass fa7d827
refactor(tests): address review feedback on hub namespace PR
Raakshass 7580712
fix(tests): remove wait from port-forward cleanup trap
Raakshass db02dfe
fix(tests): update model catalog scripts namespace to kubeflow-user-e…
Raakshass f7db495
fix(ci): broaden hub path filter and add default namespace isolation …
Raakshass d4a42e7
fix(ci): apply review feedback on default namespace guard wording
Raakshass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| namespace: kubeflow-user-example-com | ||
|
|
||
| resources: | ||
| - ../upstream/overlays/postgres | ||
| - ../upstream/options/istio | ||
| - ../upstream/options/ui/overlays/istio | ||
| - ../upstream/options/catalog/overlays/demo | ||
|
|
||
| patches: | ||
| # Gateway references: Istio resolves gateway names relative to the | ||
| # VirtualService namespace. kubeflow-gateway lives in the kubeflow namespace, | ||
| # so VirtualServices in kubeflow-user-example-com must use the fully-qualified | ||
| # cross-namespace reference. | ||
| - target: | ||
| group: networking.istio.io | ||
| version: v1alpha3 | ||
| kind: VirtualService | ||
| name: model-registry | ||
| patch: |- | ||
| - op: replace | ||
| path: /spec/gateways/0 | ||
| value: kubeflow/kubeflow-gateway | ||
| - op: replace | ||
| path: /spec/http/0/route/0/destination/host | ||
| value: model-registry-service.kubeflow-user-example-com.svc.cluster.local | ||
| - target: | ||
| group: networking.istio.io | ||
| version: v1alpha3 | ||
| kind: VirtualService | ||
| name: model-registry-ui | ||
|
Raakshass marked this conversation as resolved.
|
||
| patch: |- | ||
| - op: replace | ||
| path: /spec/gateways/0 | ||
| value: kubeflow/kubeflow-gateway | ||
| - op: replace | ||
| path: /spec/http/0/route/0/destination/host | ||
| value: model-registry-ui-service.kubeflow-user-example-com.svc.cluster.local | ||
|
|
||
| # Destination host FQDNs: services move to kubeflow-user-example-com with the | ||
| # namespace override. DestinationRule hosts must reference the correct namespace. | ||
| - target: | ||
| group: networking.istio.io | ||
| version: v1alpha3 | ||
| kind: DestinationRule | ||
| name: model-registry-service | ||
|
Raakshass marked this conversation as resolved.
|
||
| patch: |- | ||
| - op: replace | ||
| path: /spec/host | ||
| value: model-registry-service.kubeflow-user-example-com.svc.cluster.local | ||
| - target: | ||
| group: networking.istio.io | ||
| version: v1alpha3 | ||
| kind: DestinationRule | ||
| name: model-registry-ui | ||
|
Raakshass marked this conversation as resolved.
|
||
| patch: |- | ||
| - op: replace | ||
| path: /spec/host | ||
| value: model-registry-ui-service.kubeflow-user-example-com.svc.cluster.local | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.