chore: align GHA job IDs with workflow filenames#3439
Conversation
Agent-Logs-Url: https://github.com/kubeflow/manifests/sessions/33b7ad35-b1ed-4022-9549-981847b7f61c Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
|
thank you |
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Aligns GitHub Actions job IDs with their workflow filenames to make CI results easier to correlate back to the owning workflow file.
Changes:
- Renamed per-workflow job IDs from generic
buildto the workflow’s filename (without extension). - Renamed several non-
buildbut mismatched job IDs (e.g.,kubeflow-integration→full_kubeflow_integration_test,test-kserve→kserve_test,image-extraction-and-security-scan→trivy). - Standardized job ID naming across the workflows changed in this PR.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/admission_webhook_test.yaml | Rename job ID to admission_webhook_test. |
| .github/workflows/centraldashboard_test.yaml | Rename job ID to centraldashboard_test. |
| .github/workflows/dex_oauth2-proxy_test.yaml | Rename job ID to dex_oauth2-proxy_test. |
| .github/workflows/full_kubeflow_integration_test.yaml | Rename job ID to full_kubeflow_integration_test. |
| .github/workflows/istio_validation.yaml | Rename job ID to istio_validation. |
| .github/workflows/jupyter_web_application_test.yaml | Rename job ID to jupyter_web_application_test. |
| .github/workflows/katib_test.yaml | Rename job ID to katib_test. |
| .github/workflows/kserve_models_web_application_test.yaml | Rename job ID to kserve_models_web_application_test. |
| .github/workflows/kserve_test.yaml | Rename job ID to kserve_test. |
| .github/workflows/manifests_example_test.yaml | Rename job ID to manifests_example_test. |
| .github/workflows/model_catalog_test.yaml | Rename job ID to model_catalog_test. |
| .github/workflows/model_registry_test.yaml | Rename job ID to model_registry_test. |
| .github/workflows/notebook_controller_test.yaml | Rename job ID to notebook_controller_test. |
| .github/workflows/pipeline_run_from_notebook.yaml | Rename job ID to pipeline_run_from_notebook. |
| .github/workflows/pipeline_test.yaml | Rename job ID to pipeline_test. |
| .github/workflows/profiles_test.yaml | Rename job ID to profiles_test. |
| .github/workflows/ray_test.yaml | Rename job ID to ray_test. |
| .github/workflows/spark_test.yaml | Rename job ID to spark_test. |
| .github/workflows/tensorboard_controller_test.yaml | Rename job ID to tensorboard_controller_test. |
| .github/workflows/tensorboards_web_application_test.yaml | Rename job ID to tensorboards_web_application_test. |
| .github/workflows/trainer_test.yaml | Rename job ID to trainer_test. |
| .github/workflows/training_operator_test.yaml | Rename job ID to training_operator_test. |
| .github/workflows/trivy.yaml | Rename job ID to trivy. |
| .github/workflows/volumes_web_application_test.yaml | Rename job ID to volumes_web_application_test. |
| .github/workflows/welcome-new-contributors.yaml | Rename job ID to welcome-new-contributors. |
|
/reopen |
|
@juliusvonkohout: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
GHA job IDs were inconsistently named — most used the generic
build, others used arbitrary identifiers liketest-kserve,build-kfmr, orkubeflow-integration— making it hard to correlate CI failures back to source files.Changes
buildjob ID to match the workflow filename (e.g.admission_webhook_test,pipeline_test,volumes_web_application_test)buildbut still mismatched job IDs:full_kubeflow_integration_test:kubeflow-integration→full_kubeflow_integration_testkserve_test:test-kserve→kserve_testmodel_catalog_test:build-kfmc→model_catalog_testmodel_registry_test:build-kfmr→model_registry_testistio_validation:test-istio→istio_validationtrivy:image-extraction-and-security-scan→trivywelcome-new-contributors:welcome→welcome-new-contributorsstale(already matches),linting_bash_python_yaml_files(two distinct jobs —format_python_files/format_bash_files— cannot both match the filename)