Skip to content

align kserve web appLICATION helm parity#3437

Merged
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
danish9039:kserve-helm-parity-followup
Apr 4, 2026
Merged

align kserve web appLICATION helm parity#3437
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
danish9039:kserve-helm-parity-followup

Conversation

@danish9039

Copy link
Copy Markdown
Member

Follow-up to #3393.

The KServe Models Web App manifests were renamed to kserve-models-web-application, but the downstream Helm chart and Helm-vs-Kustomize comparison were still using the older kserve-models-web-app identity and stale chart defaults.

This PR updates the Helm chart to match the synced manifests, adds the missing inferencegraphs RBAC permissions, and switches the parity checks to chart-local CI values for the base and Kubeflow scenarios.

Verification:

  • bash -n tests/helm_kustomize_compare.sh
  • tests/helm_kustomize_compare.sh kserve-models-web-app base
  • tests/helm_kustomize_compare.sh kserve-models-web-app kubeflow

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
(cherry picked from commit b7e8452)
Copilot AI review requested due to automatic review settings April 3, 2026 19:52
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the KServe Models Web App Helm chart with the synced upstream manifests, following the upstream rename from kserve-models-web-app to kserve-models-web-application. The changes include:

  1. Helm Chart Alignment: Updated the chart name, labels, and image tag to match the upstream restructured manifests
  2. RBAC Permissions: Added missing inferencegraphs and inferencegraphs/status permissions to ClusterRole
  3. Test Infrastructure: Created chart-local CI values files and updated comparison logic to use them, ensuring proper parity checks between Helm and Kustomize for both base and Kubeflow scenarios

Changes:

  • Updated Helm Chart.yaml to use new chart name and appVersion 0.16.1
  • Updated component labels in Helm templates to match upstream naming convention
  • Added missing inferencegraphs RBAC permissions to align with upstream
  • Created ci/base-values.yaml and ci/kubeflow-values.yaml for scenario-specific configurations
  • Updated helm_kustomize_compare.sh to use chart-local CI values files instead of inline arguments
  • Updated helm_kustomize_compare.py to remove special-case AuthorizationPolicy expectations for base scenario

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
experimental/helm/charts/kserve-models-web-app/Chart.yaml Updated chart name and appVersion to 0.16.1
experimental/helm/charts/kserve-models-web-app/values.yaml Updated values.yaml comment and imageTag to 0.16.1
experimental/helm/charts/kserve-models-web-app/templates/_helpers.tpl Updated component label values to kserve-models-web-application
experimental/helm/charts/kserve-models-web-app/templates/rbac/clusterrole.yaml Added inferencegraphs and inferencegraphs/status RBAC permissions
experimental/helm/charts/kserve-models-web-app/ci/base-values.yaml Created with base scenario configuration
experimental/helm/charts/kserve-models-web-app/ci/kubeflow-values.yaml Created with Kubeflow scenario configuration
tests/helm_kustomize_compare.sh Updated to use chart-local CI values and correct release name
tests/helm_kustomize_compare.py Removed special-case AuthorizationPolicy expectation for base scenario

Comment thread tests/helm_kustomize_compare.sh Outdated
Comment thread experimental/helm/charts/kserve-models-web-app/templates/rbac/clusterrole.yaml Outdated
Comment thread tests/helm_kustomize_compare.py Outdated
Comment thread experimental/helm/charts/kserve-models-web-app/templates/_helpers.tpl Outdated
Comment thread experimental/helm/charts/kserve-models-web-app/values.yaml
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Comment thread tests/helm_kustomize_compare.sh Outdated
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout changed the title align kserve web app helm parity align kserve web appLICATION helm parity Apr 4, 2026
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit da8847f into kubeflow:master Apr 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants