align kserve web appLICATION helm parity#3437
Conversation
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> (cherry picked from commit b7e8452)
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
This PR aligns the KServe Models Web App Helm chart with the synced upstream manifests, following the upstream rename from kserve-models-web-app to kserve-models-web-application. The changes include:
- Helm Chart Alignment: Updated the chart name, labels, and image tag to match the upstream restructured manifests
- RBAC Permissions: Added missing
inferencegraphsandinferencegraphs/statuspermissions to ClusterRole - Test Infrastructure: Created chart-local CI values files and updated comparison logic to use them, ensuring proper parity checks between Helm and Kustomize for both base and Kubeflow scenarios
Changes:
- Updated Helm Chart.yaml to use new chart name and appVersion 0.16.1
- Updated component labels in Helm templates to match upstream naming convention
- Added missing inferencegraphs RBAC permissions to align with upstream
- Created ci/base-values.yaml and ci/kubeflow-values.yaml for scenario-specific configurations
- Updated helm_kustomize_compare.sh to use chart-local CI values files instead of inline arguments
- Updated helm_kustomize_compare.py to remove special-case AuthorizationPolicy expectations for base scenario
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| experimental/helm/charts/kserve-models-web-app/Chart.yaml | Updated chart name and appVersion to 0.16.1 |
| experimental/helm/charts/kserve-models-web-app/values.yaml | Updated values.yaml comment and imageTag to 0.16.1 |
| experimental/helm/charts/kserve-models-web-app/templates/_helpers.tpl | Updated component label values to kserve-models-web-application |
| experimental/helm/charts/kserve-models-web-app/templates/rbac/clusterrole.yaml | Added inferencegraphs and inferencegraphs/status RBAC permissions |
| experimental/helm/charts/kserve-models-web-app/ci/base-values.yaml | Created with base scenario configuration |
| experimental/helm/charts/kserve-models-web-app/ci/kubeflow-values.yaml | Created with Kubeflow scenario configuration |
| tests/helm_kustomize_compare.sh | Updated to use chart-local CI values and correct release name |
| tests/helm_kustomize_compare.py | Removed special-case AuthorizationPolicy expectation for base scenario |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
Thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow-up to #3393.
The KServe Models Web App manifests were renamed to
kserve-models-web-application, but the downstream Helm chart and Helm-vs-Kustomize comparison were still using the olderkserve-models-web-appidentity and stale chart defaults.This PR updates the Helm chart to match the synced manifests, adds the missing
inferencegraphsRBAC permissions, and switches the parity checks to chart-local CI values for the base and Kubeflow scenarios.Verification:
bash -n tests/helm_kustomize_compare.shtests/helm_kustomize_compare.sh kserve-models-web-app basetests/helm_kustomize_compare.sh kserve-models-web-app kubeflow