fix-trivy-helm GHA#3411
Conversation
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows and introduces a Kustomize installer script to support CI jobs that compare Helm vs Kustomize and run Trivy-related checks.
Changes:
- Added
tests/kustomize_install.shto download and checksum-verify a pinned Kustomize binary. - Updated workflow
pull_request.pathsfilters to include the new installer and related scripts. - Adjusted Helm-vs-Kustomize workflow triggers (notably removing the
branches: [master]restriction).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/kustomize_install.sh | Adds a checksum-verified Kustomize install helper for CI/test scripts. |
| .github/workflows/trivy.yaml | Expands PR path filters to rerun Trivy workflow when relevant scripts change. |
| .github/workflows/helm-kustomize-comparison.yml | Updates PR path filters and changes PR trigger behavior by dropping branch restriction. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I am force merging, since the helm tests are blocking. |
Do I create a seperate pr to update all of helm charts to match with latest kustomize ? |
Yes please raise a seperate PR to do that |
* fix-trivy-helm GHA Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update paths format in Helm vs Kustomize workflow Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Add kustomize_install.sh to workflow trigger paths Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pull request paths in trivy.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * . Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * . Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * . Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * . Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@tarekabouzeid