block-impersonating-serviceaccounts#3372
Conversation
block-impersonating-serviceaccounts Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the impersonate verb on core serviceaccounts from the Kubeflow aggregated ClusterRole rules, preventing Kubeflow roles from being able to impersonate ServiceAccounts.
Changes:
- Removed RBAC rule granting
impersonateonserviceaccountsfromkubeflow-kubernetes-editClusterRole rules.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Thank you for addressing and merging the fix. |
block-impersonating-serviceaccounts Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@tarekabouzeid