test(ci): harden Kustomize checksum verification#3368
Conversation
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
Hardens the shared CI bootstrap step that downloads and verifies Kustomize in the KinD-based test setup, aiming to reduce flaky failures during checksum verification before component tests run.
Changes:
- Introduces an explicit
KUSTOMIZE_ASSETvariable to avoid repeating the asset name. - Uses
curl --fail --show-errorfor clearer and earlier failures on bad HTTP responses. - Filters
checksums.txtto the exact expected asset entry before runningsha256sum --check.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
|
thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* test(ci): harden Kustomize checksum verification Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> * Update tests/install_KinD_create_KinD_cluster_install_kustomize.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> --------- Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✏️ Summary of Changes
This PR hardens the shared Kustomize install path in
tests/install_KinD_create_KinD_cluster_install_kustomize.sh.The recent CI failures were happening before any component-specific tests ran, during the Kustomize bootstrap step. Across reruns, the failure signature varied:
checksums.txt: no properly formatted checksum lines foundThis change makes the Kustomize verification step more explicit and less brittle by:
kustomize_v5.7.1_linux_amd64.tar.gz),curl --fail --show-errorso bad HTTP responses fail earlier and more clearly,This is intentionally scoped to the shared CI/bootstrap path and does not modify any component manifests.
📦 Dependencies
🐛 Related Issues
Install KinD, Create KinD cluster and Install kustomizestep, observed while validating#3367.✅ Validation
Validated locally against the current upstream
kustomize/v5.7.1release metadata and download assets:Observed result:
✅ Contributor Checklist