fix: variable namespaces for networkpolicies

[juhyeon-cha]

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

The problem is that all NetworkPolicies are being created in the kubeflow namespace because the namespace value is present in kustomization.yaml.

✅ Contributor Checklist

• I have tested these changes with kustomize. See Installation Prerequisites.
• All commits are signed-off to satisfy the DCO check.
• I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

---

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

[juhyeon-cha]

@juliusvonkohout Until recently, common/networkpolicies only contained policies for the kubeflow namespace.
Since this commit (3c338f4), policies for several namespaces, including kubeflow-system and cert-manager, have been added, but the namespace value in kustomization.yaml is changed to the kubeflow namespace.

https://github.com/kubeflow/manifests/blob/d23d747a05ca59e48c4bfbf039d23f4f3e6e2384/common/networkpolicies/base/cert-manager-webhook.yaml#L1-L7

[juliusvonkohout]

@kunal-511 may you take a look?

I think we need to adjust the test scripts then to only use the specific networkpolicies. Or we make our life easier and just create the namespaces in the multi-tenancy script if they do not exist yet.
But to properly install parts of kubeflow we need to move them to the per application folders and upstream them long-term.

Error from server (NotFound): error when creating "STDIN": namespaces "auth" not found
Error from server (NotFound): error when creating "STDIN": namespaces "knative-serving" not found
Error: Process completed with exit code 1.

I will also do some dummy istio changes to trigger most tests.

[juliusvonkohout]

Thank you @juhyeon-cha

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kunal-511]

I think we need to adjust the test scripts then to only use the specific networkpolicies. Or we make our life easier and just create the namespaces in the multi-tenancy script if they do not exist yet.

Okay I think currently creating namespace in multi-tenancy script if they do not exist will work?
Will raise the PR

[juliusvonkohout]

I think especially everything outside of the kubeflow namespaces so cert-manager, knative-serving etc. We should directly move in this PR to the respective folders.

[juliusvonkohout]

@juhyeon-cha do you want to continue here? Otherwise we will for and continue.

[juhyeon-cha]

@juliusvonkohout I'm good for now, so please feel free to take over. Thanks!

[danish9039]

@juliusvonkohout i can take this up

[danish9039]

/assign