Skip to content

Update synchronize istio to include ztunnel support#3274

Merged
google-oss-prow[bot] merged 15 commits into
kubeflow:masterfrom
kunal-511:ztunnel-manifests-generation
Nov 18, 2025
Merged

Update synchronize istio to include ztunnel support#3274
google-oss-prow[bot] merged 15 commits into
kubeflow:masterfrom
kunal-511:ztunnel-manifests-generation

Conversation

@kunal-511

@kunal-511 kunal-511 commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Update split-istio-packages script to extract ztunnel resources
Update synchronize-istio-manifests to generate ztunnel manifests with ambient mode enabled

🐛 Related Issues

#3246

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@kunal-511

kunal-511 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@kunal-511

kunal-511 commented Nov 16, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@kunal-511 @juliusvonkohout
Update synchronize istio to include ztunnel support
569ce0a 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511 @juliusvonkohout
increase katib test timeout
771f702 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout juliusvonkohout force-pushed the ztunnel-manifests-generation branch from 7763e4b to 771f702 Compare November 17, 2025 16:26
juliusvonkohout
juliusvonkohout reviewed Nov 17, 2025
View reviewed changes
Comment thread tests/katib_test.sh
@juliusvonkohout

juliusvonkohout commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you for the PR. I think github was a bit slow which lead to failed tests. I retriggered all tests. Probably you can revert the Katib timeout.

@kunal-511
revert katib test timeout
a876b9a 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout

juliusvonkohout commented Nov 17, 2025

Copy link
Copy Markdown
Member

You cal also always retest with /retest if needed

@juliusvonkohout
Update error handling in free-disk-space.sh
5f22620 
Enable debugging options in free-disk-space.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot added size/M and removed size/S labels Nov 17, 2025
@juliusvonkohout
Update full_kubeflow_integration_test.yaml
8cb492c 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update pipeline_test.yaml
585c8bf 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Upgrade checkout action from v4 to v5
a034b44 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update checkout action version in pipeline test
67d7831 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Make tests/free-disk-space.sh executable
b24a6e2 
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
juliusvonkohout
juliusvonkohout reviewed Nov 17, 2025
View reviewed changes
Comment thread common/istio/split-istio-packages
@juliusvonkohout
Remove apt-get autoremove from cleanup script
1d47ea7 
Removed 'apt-get autoremove' command from the script.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update GitHub Actions workflow for disk space management
2a193df 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update katib_test.sh
5df884c 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Upgrade checkout action and add disk space cleanup
b763c37 
Updated checkout action version and added disk space cleanup step.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout

juliusvonkohout commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

And i am still wondering why the DEX test is so unreliable https://github.com/kubeflow/manifests/actions/runs/19438990652/job/55622642323 is so unreliable

@juliusvonkohout

juliusvonkohout commented Nov 17, 2025

Copy link
Copy Markdown
Member

Lets wait with merging until #3274 (comment) is resolved

@juliusvonkohout

juliusvonkohout commented Nov 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you

/lgtm
/approve

and here is the istio PR for your /lgtm #3275

@google-oss-prow google-oss-prow Bot added the lgtm label Nov 18, 2025
@google-oss-prow

google-oss-prow Bot commented Nov 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout mentioned this pull request Nov 18, 2025
Closed
@google-oss-prow google-oss-prow Bot merged commit 482c179 into kubeflow:master Nov 18, 2025
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout juliusvonkohout left review comments

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunal-511 @juliusvonkohout