Tests for Model Catalog#3262
Conversation
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
tarilabs
left a comment
There was a problem hiding this comment.
thank you so much @kunal-511 this
/lgtm
already, just minor comment below which I didn't fully grok
cc @pboyd can you also kindly check please?
the goal here is to make a quick test that a Catalog API responds if the Manifests are deployed, ref kubeflow/hub#1685
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
|
Should we just merge this with the model registry files or do you want to have it explicitly separate @tarilabs ? |
I'd prefer to keep these separate GHA and scripts, if that is okay with you, as we'd like to showcase Catalog also independently of Registry. Further will help pin-point if either fails their check. Wdyt? |
pboyd
left a comment
There was a problem hiding this comment.
Looks good to me.
Fair warning though, we've tweaked a few things upstream and we'll need some changes to this test when we bring those changes back down. Namely, we fixed some of the redundant names and added an optional istio overlay.
Co-authored-by: Paul Boyd <paul@pboyd.io> Signed-off-by: Kunal Dugar <yoyokvunal@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
Strange, i see in kubeflow-trainer-controller-manager in kubeflow-system |
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
/lgtm |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist