Skip to content

Tests for Model Catalog#3262

Merged
google-oss-prow[bot] merged 13 commits into
kubeflow:masterfrom
kunal-511:gha-test-model-catalog
Oct 24, 2025
Merged

Tests for Model Catalog#3262
google-oss-prow[bot] merged 13 commits into
kubeflow:masterfrom
kunal-511:gha-test-model-catalog

Conversation

@kunal-511

@kunal-511 kunal-511 commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Gha test for Model Catalog

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

@tarilabs tarilabs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @kunal-511 this
/lgtm
already, just minor comment below which I didn't fully grok

cc @pboyd can you also kindly check please?
the goal here is to make a quick test that a Catalog API responds if the Manifests are deployed, ref kubeflow/hub#1685

Comment thread .github/workflows/model_catalog_test.yaml Outdated
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label Oct 24, 2025
@juliusvonkohout

juliusvonkohout commented Oct 24, 2025

Copy link
Copy Markdown
Member

Should we just merge this with the model registry files or do you want to have it explicitly separate @tarilabs ?

@tarilabs

Copy link
Copy Markdown
Member

Should we just merge this with the model registry files or do you want to have it explicitly separate @tarilabs ?

I'd prefer to keep these separate GHA and scripts, if that is okay with you, as we'd like to showcase Catalog also independently of Registry. Further will help pin-point if either fails their check. Wdyt?

@pboyd pboyd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Fair warning though, we've tweaked a few things upstream and we'll need some changes to this test when we bring those changes back down. Namely, we fixed some of the redundant names and added an optional istio overlay.

Comment thread tests/model_catalog_install.sh Outdated
Co-authored-by: Paul Boyd <paul@pboyd.io>
Signed-off-by: Kunal Dugar <yoyokvunal@gmail.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label Oct 24, 2025
@google-oss-prow google-oss-prow Bot added the lgtm label Oct 24, 2025
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot added lgtm and removed lgtm labels Oct 24, 2025
@juliusvonkohout

juliusvonkohout commented Oct 24, 2025

Copy link
Copy Markdown
Member

Strange, i see

{"level":"info","ts":"2025-10-24T13:50:52.002205822Z","logger":"setup","caller":"trainer-controller-manager/main.go:93","msg":"Loading configuration","configFile":""}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x13def43]

goroutine 1 [running]:
github.com/kubeflow/trainer/v2/pkg/config.addTo(0xc0003b6fd0, 0xc000231040, 0x40?)
	/workspace/pkg/config/config.go:71 +0x1c3
github.com/kubeflow/trainer/v2/pkg/config.Load(_, {_, _}, _)
	/workspace/pkg/config/config.go:128 +0x216
main.main()
	/workspace/cmd/trainer-controller-manager/main.go:94 +0x3a5

in kubeflow-trainer-controller-manager in kubeflow-system
probably because of https://github.com/kubeflow/manifests/blob/65245b29afe55d5d7b699fdf33903b32e21db9f5/applications/trainer/upstream/overlays/manager/kustomization.yaml#L18

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label Oct 24, 2025
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow Bot removed the lgtm label Oct 24, 2025
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@kubeflow kubeflow deleted a comment from google-oss-prow Bot Oct 24, 2025
@kubeflow kubeflow deleted a comment from google-oss-prow Bot Oct 24, 2025
@juliusvonkohout

Copy link
Copy Markdown
Member

/lgtm
/unhold
thank you

@google-oss-prow google-oss-prow Bot merged commit 3247f52 into kubeflow:master Oct 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants