Default to SeaweedFS instead of MinIO#3240
Conversation
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
|
/retest |
There was a problem hiding this comment.
We can just delete the policy. We will anyway get it from common/networkpolicies by default.
There was a problem hiding this comment.
Test are failing cause when tests install pipelines form /experimental/seaweedfs/istio it dosent include networkpolicies from common folder. maybe we can keep the allow-same-namespace networkpolicy till the next kfp release, then kfp will have this networkpolicy by default
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
| - ../common/kubeflow-roles/base | ||
| # Kubeflow Istio Resources | ||
| - ../common/istio/kubeflow-istio-resources/base | ||
| # Kubeflow Pipelines |
There was a problem hiding this comment.
Please comment it out as in the other PR. and add a TODO to reenable this after the next kfp release as in the other PR.
|
Please also check that it is really the same as we have in KFP for example we did some changes later on. We switched the pvc size to 20 GB and disabled pre allocation etc. It should be the same content as in the kfp repository. |
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
✅ Contributor Checklist