Skip to content

Updated tests file naming scheme#3144

Merged
google-oss-prow[bot] merged 11 commits into
kubeflow:masterfrom
kunal-511:updated-tests-naming
Jun 3, 2025
Merged

Updated tests file naming scheme#3144
google-oss-prow[bot] merged 11 commits into
kubeflow:masterfrom
kunal-511:updated-tests-naming

Conversation

@kunal-511

@kunal-511 kunal-511 commented May 28, 2025

Copy link
Copy Markdown
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Moved all the files from /tests/gh-actions -----> /tests ( as suggested)
Updated the naming scheme according to this format componentName_{install.sh, test.sh, test.py, test.yaml}

🐛 Related Issues

#3054

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
kunal-511 added 6 commits May 28, 2025 16:06
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

Please also

  1. rename run_and_wait_kubeflow_pipeline.py to pipelines_...
  2. baseline_PSS_enable should be Pss_baseline_enable
  3. restricted_PSS_enable should also be renamed to pss_restricted_enable
  4. in the trigger path replace tests/cert_manager_install.sh everywhere with tests/istio*
  5. https://github.com/kubeflow/manifests/actions/runs/15299848064/job/43037470767?pr=3144 is failing heavily.
    image

kunal-511 added 3 commits May 29, 2025 23:55
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
- apps/admission-webhook/upstream/**
- tests/gh-actions/install_istio*.sh
- tests/gh-actions/install_cert_manager.sh
- tests/istio-cni_install.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now obsolete

- tests/gh-actions/install_istio*.sh
- tests/gh-actions/install_cert_manager.sh
- tests/istio-cni_install.sh
- tests/istio*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing in most workflows and should replace the line above

- .github/workflows/centraldashboard_test.yaml
- apps/centraldashboard/upstream/**
- tests/gh-actions/install_istio*.sh
- tests/istio-cni_install.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please everywhere tests/istio*

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this everywhere

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 4d86c52 into kubeflow:master Jun 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants