Skip to content

The test_pipeline.py has been changed to test_pipeline_v2.py#3136

Merged
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
madmecodes:fix-test-pipeline-v2
May 20, 2025
Merged

The test_pipeline.py has been changed to test_pipeline_v2.py#3136
google-oss-prow[bot] merged 3 commits into
kubeflow:masterfrom
madmecodes:fix-test-pipeline-v2

Conversation

@madmecodes

Copy link
Copy Markdown
Contributor

The test_pipeline.py has been changed to test_pipeline_v2.py in #3129

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

Let's tes V1 and V2 here, as we do in the regular kfp test :-)

Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@google-oss-prow google-oss-prow Bot added size/S and removed size/XS labels May 19, 2025
@madmecodes

Copy link
Copy Markdown
Contributor Author

Let's tes V1 and V2 here, as we do in the regular kfp test :-)

you meant these tests right?

@madmecodes

Copy link
Copy Markdown
Contributor Author

seems like test_pipeline_v1.py doesnt supports the same command-line parameters as test_pipeline_v2.py
let me check

@madmecodes

madmecodes commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

@juliusvonkohout

PS: List and deploy test pipeline uses both V2 and V1 API & Fail to tests uses V2 only

The V1 script (test_pipeline_v1.py) doesn't have a test_unauthorized_access function like the V2 script has. It only supports running the pipeline.
Shall I

  1. Remove the V1 unauthorized access test from the workflow OR
  2. Add test_unauthorized_access functionality to test_pipeline_v1.py

Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 39c0ff6 into kubeflow:master May 20, 2025
8 checks passed
@madmecodes

Copy link
Copy Markdown
Contributor Author

okay, now i will rebase #3135

@juliusvonkohout

Copy link
Copy Markdown
Member

okay, now i will rebase #3135

yes and please also reenable the trigger paths for the seweedfs workflow at the top of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants