Skip to content

Add KFP V1 Pipeline Test to CI Workflow#3127

Merged
google-oss-prow[bot] merged 14 commits into
kubeflow:masterfrom
kunal-511:add-kfp-v1-pipeline-test
May 11, 2025
Merged

Add KFP V1 Pipeline Test to CI Workflow#3127
google-oss-prow[bot] merged 14 commits into
kubeflow:masterfrom
kunal-511:add-kfp-v1-pipeline-test

Conversation

@kunal-511

@kunal-511 kunal-511 commented May 11, 2025

Copy link
Copy Markdown
Contributor

✏️ Summary of Changes

Added KFP v1 SDK (>=1.8.22,<2.0.0) pipeline test to CI workflow
Create simple hello world V1 pipeline test script

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
kunal-511 and others added 13 commits May 11, 2025 10:42
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout

juliusvonkohout commented May 11, 2025

Copy link
Copy Markdown
Member

Thank you @kunal-511 .

  1. I also think that the v2 pipeline test is still somewhat unstable. Can you make it more robust / deterministic in a separate PR ? Also in tests /gh-actions.
  2. We should change the naming scheme so spark_install, spark, test, kserve_install, kserve_test etc. such that /tests/componentName_{install.sh, test.sh, test.py, test.yaml} for all files. Also the https://github.com/kunal-511/kubeflow-manifests/tree/add-kfp-v1-pipeline-test/tests/gh-actions/kf-objects files can be split up to be next to the other files per component. Lets also get rid of the tests/gh-actions and just have the files directly under /tests
  3. https://github.com/kubeflow/manifests/blob/master/scripts/trivy_scan.py also belongs to /tests

Please split this up in separate PRs

@juliusvonkohout juliusvonkohout added this to the 1.10.1 milestone May 11, 2025
@juliusvonkohout

Copy link
Copy Markdown
Member

/lgtm
/approve

please continue with #3127 (comment)

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 12394f6 into kubeflow:master May 11, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants