Updated the gha workflows to use new install_katib, made changes as s…

[kunal-511]

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Addd a new file for katib install, then updated 2 gha workflows to use them directly.
Updated the install_knative-cni.sh to be consistent with the install_knative.sh
Follow up PR of #3077

🐛 Related Issues

Fix #3054

✅ Contributor Checklist

• I have tested these changes with kustomize. See Installation Prerequisites.
• All commits are signed-off to satisfy the DCO check.

---

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

[juliusvonkohout]

/lgtm
/approve

Can you in a follow up PR change .github/workflows/katib_test.yaml to use a real Kubeflow profile and multi-tenancy installation?

    - name: Install Certificate Manager
      run: ./tests/gh-actions/install_cert_manager.sh
    - name: Install Istio CNI
      run: ./tests/gh-actions/install_istio-cni.sh
    - name: Install OAuth2 Proxy
      run: ./tests/gh-actions/install_oauth2-proxy.sh
    - name: Install Kubeflow Istio Resources
      run: kustomize build common/istio-cni-1-24/kubeflow-istio-resources/base | kubectl apply -f -
    - name: Install Multi-Tenancy
      run: ./tests/gh-actions/install_multi_tenancy.sh
    - name: Create KF Profile
      run: ./tests/gh-actions/install_kubeflow_profile.sh

and remove

name: Create namespaces

Then you can also simplify

    - name: Run Katib Test
      run: |
        sed "s/kubeflow-user/$KF_PROFILE/g" tests/gh-actions/kf-objects/katib_test.yaml | kubectl apply -f -
        kubectl wait --for=condition=Running experiments.kubeflow.org -n $KF_PROFILE --all --timeout=300s
        sleep 30

and add tests as here https://github.com/kubeflow/manifests/blob/4b750ba1106c127668340be13d1fe708fc75c3bd/.github/workflows/pipeline_test.yaml#L66 with a real user

Probably the same is true for training-operator

    - name: Run Training Operator Test
      run: |
        sed 's/namespace: .*/namespace: '"$KF_PROFILE"'/g' tests/gh-actions/kf-objects/training_operator_job.yaml | kubectl apply -f -

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kunal-511]

/lgtm /approve

Can you in a follow up PR change .github/workflows/katib_test.yaml to use a real Kubeflow profile and multi-tenancy installation?

    - name: Install Certificate Manager
      run: ./tests/gh-actions/install_cert_manager.sh
    - name: Install Istio CNI
      run: ./tests/gh-actions/install_istio-cni.sh
    - name: Install OAuth2 Proxy
      run: ./tests/gh-actions/install_oauth2-proxy.sh
    - name: Install Kubeflow Istio Resources
      run: kustomize build common/istio-cni-1-24/kubeflow-istio-resources/base | kubectl apply -f -
    - name: Install Multi-Tenancy
      run: ./tests/gh-actions/install_multi_tenancy.sh
    - name: Create KF Profile
      run: ./tests/gh-actions/install_kubeflow_profile.sh

and remove

name: Create namespaces

Then you can also simplify

    - name: Run Katib Test
      run: |
        sed "s/kubeflow-user/$KF_PROFILE/g" tests/gh-actions/kf-objects/katib_test.yaml | kubectl apply -f -
        kubectl wait --for=condition=Running experiments.kubeflow.org -n $KF_PROFILE --all --timeout=300s
        sleep 30

and add tests as here

https://github.com/kubeflow/manifests/blob/4b750ba1106c127668340be13d1fe708fc75c3bd/.github/workflows/pipeline_test.yaml#L66
with a real user

okay i will create a follow up pr for this

[juliusvonkohout]

/lgtm /approve
Can you in a follow up PR change .github/workflows/katib_test.yaml to use a real Kubeflow profile and multi-tenancy installation?

    - name: Install Certificate Manager
      run: ./tests/gh-actions/install_cert_manager.sh
    - name: Install Istio CNI
      run: ./tests/gh-actions/install_istio-cni.sh
    - name: Install OAuth2 Proxy
      run: ./tests/gh-actions/install_oauth2-proxy.sh
    - name: Install Kubeflow Istio Resources
      run: kustomize build common/istio-cni-1-24/kubeflow-istio-resources/base | kubectl apply -f -
    - name: Install Multi-Tenancy
      run: ./tests/gh-actions/install_multi_tenancy.sh
    - name: Create KF Profile
      run: ./tests/gh-actions/install_kubeflow_profile.sh

and remove

name: Create namespaces

Then you can also simplify

    - name: Run Katib Test
      run: |
        sed "s/kubeflow-user/$KF_PROFILE/g" tests/gh-actions/kf-objects/katib_test.yaml | kubectl apply -f -
        kubectl wait --for=condition=Running experiments.kubeflow.org -n $KF_PROFILE --all --timeout=300s
        sleep 30

and add tests as here
https://github.com/kubeflow/manifests/blob/4b750ba1106c127668340be13d1fe708fc75c3bd/.github/workflows/pipeline_test.yaml#L66

with a real user

okay i will create a follow up pr for this

Probably training operator has the same problem and does not test in a real KF profile namespace.