-
Notifications
You must be signed in to change notification settings - Fork 1.1k
end-to-end integration tests #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
google-oss-prow
merged 67 commits into
kubeflow:master
from
kunal-511:fix#3070/kubeflow-full-integration-test
Apr 8, 2025
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
1f73004
Ensure proper installation of Katib and KServe
kunal-511 090e2d2
Fixed the lint issues
kunal-511 feaf114
Fix Katib and KServe test sections, improve debugging
kunal-511 f352fad
Fix MySQL timeout in Kind by improving wait strategy and timeouts
kunal-511 8e70ed4
fixed the Dex login test
kunal-511 f716f24
Updated the file for knative
kunal-511 23d01a3
This change will prevent the timeout issue because it focuses only on…
kunal-511 ffa0d12
Fix KServe test by improving diagnostics, auth, and inference service…
kunal-511 c29682d
Using indvidual tests only
kunal-511 f11e468
seperated the installation and test, updated naming
kunal-511 46a81bd
Updated test_sklearn.py to directly use a string literal InferenceSer…
kunal-511 765c00e
Fixed the path to spark operator
kunal-511 443d9be
Make sure to be in root before running spark installation
kunal-511 da658fe
Moved the verification steps to individual scripts
kunal-511 d6f747a
Fixed the connection error
kunal-511 9d2ebaa
This ensures the directory exists before attempting to write to it
kunal-511 a8ba77b
Fixed the cluster consistency
kunal-511 d08f6d8
Fixed the kind cluster config issues
kunal-511 783701d
removed the kind cluster way to handle this
kunal-511 97b70c7
Fixed connection issue
kunal-511 fa3b966
Fixed istio port forward
kunal-511 aacaf5f
Added the dex auth test script
kunal-511 47e5489
Fixed dex test
kunal-511 d94ac55
Fixed the crd path
kunal-511 eb25472
Fixed the notebook crd error
kunal-511 3b58dfa
Revert back to previous commit
kunal-511 d10cb93
fixed the issue by updating the workflow to ensure the PodDefault CR…
kunal-511 7c178ef
Fixed namespace error in notebook tests
kunal-511 3248363
Fixed namespace error in notebook tests
kunal-511 5a52657
Converted this job into one single only
kunal-511 481b323
Fixed file path in spark test
kunal-511 6914544
Fixed the spark test error
kunal-511 6171206
Fixed the pods security error
kunal-511 61e6077
Modified the pods security to report error but not fail
kunal-511 7ea9ad7
update the inline PodDefaults and Notebook definition in the full_kub…
kunal-511 25c370d
Update full_kubeflow_integration_test.yaml
juliusvonkohout a45355f
Made the workflow minimal
kunal-511 ed02853
Fixed the issue causing 403, 404 error in testing dex auth
kunal-511 ac7de3f
fixed the script by replacing the problematic sed commands
kunal-511 984923a
fixed the patching script
kunal-511 3e7fe37
Fixed the test-0 pod not found error
kunal-511 06a883c
Fixed issue that notebook authentication problem
kunal-511 d5c2da0
removed the --user=jovyan flag
kunal-511 94a8833
fixed auth issue without interfering with other workflow
kunal-511 3ff1ef4
Modifying the script to use environment variables Instead of trying t…
kunal-511 49e5aa6
modified the token creation to include the proper audience
kunal-511 7c7b1a7
Apply suggestions from code review
juliusvonkohout f1fb774
Apply suggestions from code review
juliusvonkohout 0af74fd
Apply suggestions from code review
juliusvonkohout 21f4bd3
Update install_knative.sh
juliusvonkohout b109afe
applied suugested changes
kunal-511 609ae6f
removed not needed comments
kunal-511 7583eab
updated according to suggested changes
kunal-511 8a229d8
Fixed the duplicate istio installation
kunal-511 8dca0b4
Apply suggestions from code review
juliusvonkohout 0fe7ae1
Created individual components to be used as reusable scripts
kunal-511 4f1ce55
fixed teh oauth credential issue
kunal-511 65311b7
Fixed the notebook token issue
kunal-511 e7dc612
Fixed as suggested
kunal-511 153880f
removed not needed echo, comment and files
kunal-511 8bdf811
Update .github/workflows/full_kubeflow_integration_test.yaml
kunal-511 7132b1d
Update .github/workflows/full_kubeflow_integration_test.yaml
kunal-511 997bcc4
updated as suggested
kunal-511 25e4d12
remove overhead
juliusvonkohout 9d00004
Update install_kubeflow_profile.sh
juliusvonkohout b29d99c
Rolled back the test dex login, removed not needed comments
kunal-511 c1a3bc5
Fixed lint and namespace error
kunal-511 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
360 changes: 136 additions & 224 deletions
360
.github/workflows/full_kubeflow_integration_test.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. set -euxo pipefail is what you need
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's do this in a follow up PR. |
||
|
|
||
| kustomize build apps/centraldashboard/upstream/overlays/kserve | kubectl apply -f - | ||
| kubectl wait --for=condition=Ready pods --all -n kubeflow --timeout=180s | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/bin/bash | ||
| set -euxo pipefail | ||
|
|
||
| kustomize build ./common/dex/overlays/oauth2-proxy | kubectl apply -f - | ||
| kubectl wait --for=condition=Ready pods --all --timeout=180s -n auth |
|
juliusvonkohout marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/bin/bash | ||
| set -euxo | ||
| kustomize build common/user-namespace/base | kubectl apply -f - | ||
| sleep 30 # Let the profile controler reconcile the namespace | ||
| PROFILE_CONTROLLER_POD=$(kubectl get pods -n kubeflow -o json | jq -r '.items[] | select(.metadata.name | startswith("profiles-deployment")) | .metadata.name') | ||
| kubectl logs -n kubeflow "$PROFILE_CONTROLLER_POD" | ||
| KF_PROFILE=kubeflow-user-example-com | ||
| kubectl -n $KF_PROFILE get pods,configmaps,secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
juliusvonkohout marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.