Skip to content

feat: remove outdated metadata UI manifests #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Nov 11, 2020
Merged

feat: remove outdated metadata UI manifests #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91cce4e
feat: remove outdated metadata UI manifests
Bobgy Nov 9, 2020
23e14cb
update again and snapshots
Bobgy Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions metadata/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,17 @@ generatorOptions:
resources:
- metadata-deployment.yaml
- metadata-service.yaml
- metadata-ui-deployment.yaml
- metadata-ui-role.yaml
- metadata-ui-rolebinding.yaml
- metadata-ui-sa.yaml
- metadata-ui-service.yaml
- metadata-envoy-deployment.yaml
- metadata-envoy-service.yaml
namespace: kubeflow
vars:
# These vars are used internally for the kustomize package.
# i.e to substitute values into fields kustomize isn't aware of.
# The names should be unique enough that we don't get conflicts with other packages
- name: ui-namespace
- name: metadata-namespace
objref:
kind: Service
name: ui
name: envoy-service
apiVersion: v1
fieldref:
fieldpath: metadata.namespace
Expand All @@ -43,13 +38,6 @@ vars:
version: v1
fieldref:
fieldpath: data.uiClusterDomain
- name: metadata-service

@Jeffwan Jeffwan Nov 9, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for metadata-service not ui-service.?

@Bobgy Bobgy Nov 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obj reference targets UI service, and I removed its usage.

Do we still need to keep metadata server?
If yes, how do people access it? And how do people access it before? Was the UI service a proxy to the server?

@Jeffwan @zhenghuiwang

@Jeffwan Jeffwan Nov 11, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discuss this in another thread. I think we all agree to remove this. kubeflow/metadata#250

objref:
kind: Service
name: ui
apiVersion: v1
fieldref:
fieldpath: metadata.name
- name: metadata-envoy-service
objref:
kind: Service
Expand All @@ -70,6 +58,3 @@ images:
- name: mysql
newName: mysql
newTag: 8.0.3
- name: gcr.io/kubeflow-images-public/metadata-frontend
newName: gcr.io/kubeflow-images-public/metadata-frontend
newTag: v0.1.8
26 changes: 0 additions & 26 deletions metadata/base/metadata-ui-deployment.yaml
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions metadata/base/metadata-ui-role.yaml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions metadata/base/metadata-ui-rolebinding.yaml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions metadata/base/metadata-ui-sa.yaml
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions metadata/base/metadata-ui-service.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion metadata/overlays/istio/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ kind: Kustomization
bases:
- ../../base
resources:
- virtual-service.yaml
- virtual-service-metadata-grpc.yaml
configurations:
- params.yaml
2 changes: 1 addition & 1 deletion metadata/overlays/istio/virtual-service-metadata-grpc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
uri: /ml_metadata
route:
- destination:
host: $(metadata-envoy-service).$(ui-namespace).svc.$(ui-clusterDomain)
host: $(metadata-envoy-service).$(metadata-namespace).svc.$(ui-clusterDomain)
port:
number: 9090
timeout: 300s
21 changes: 0 additions & 21 deletions metadata/overlays/istio/virtual-service.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion metadata/v3/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../overlays/db
- ../overlays/istio/virtual-service.yaml
- ../overlays/istio/virtual-service-metadata-grpc.yaml
configurations:
- params.yaml
1 change: 0 additions & 1 deletion stacks/ibm/application/metadata/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ commonLabels:
resources:
- ../../../../metadata/overlays/db
- ../../../../metadata/overlays/application/application.yaml
- ../../../../metadata/overlays/istio/virtual-service.yaml
- ../../../../metadata/overlays/istio/virtual-service-metadata-grpc.yaml
configurations:
- ../../../../metadata/overlays/istio/params.yaml
Expand Down
1 change: 0 additions & 1 deletion tests/legacy_kustomizations/metadata/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ patches: []
patchesStrategicMerge:
- ../../../metadata/overlays/db/metadata-deployment.yaml
resources:
- ../../../metadata/overlays/istio/virtual-service.yaml
- ../../../metadata/overlays/istio/virtual-service-metadata-grpc.yaml
- ../../../metadata/overlays/application/application.yaml
- ../../../metadata/overlays/db/metadata-db-pvc.yaml
Expand Down
29 changes: 0 additions & 29 deletions tests/stacks/aws/test_data/expected/apps_v1_deployment_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions ...tacks/aws/test_data/expected/networking.istio.io_v1alpha3_virtualservice_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions tests/stacks/aws/test_data/expected/rbac.authorization.k8s.io_v1beta1_role_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions ...cks/aws/test_data/expected/rbac.authorization.k8s.io_v1beta1_rolebinding_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions tests/stacks/aws/test_data/expected/~g_v1_service_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/stacks/aws/test_data/expected/~g_v1_serviceaccount_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions tests/stacks/examples/alice/test_data/expected/apps_v1_deployment_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions ...les/alice/test_data/expected/networking.istio.io_v1alpha3_virtualservice_metadata-ui.yaml
View file
Open in desktop

This file was deleted.

Loading