Skip to content

Remove http from the GCP ingress and explicitly set the default backend. #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Aug 27, 2020
Merged

Remove http from the GCP ingress and explicitly set the default backend. #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gcp/iap-ingress/base/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
annotations:
ingress.kubernetes.io/ssl-redirect: "true"
kubernetes.io/ingress.allow-http: "false"
kubernetes.io/ingress.global-static-ip-name: $(ipName)
networking.gke.io/managed-certificates: gke-certificate
name: envoy-ingress
spec:
backend:
serviceName: istio-ingressgateway
servicePort: 80
rules:
- host: $(hostname)
http:
Expand Down
1 change: 0 additions & 1 deletion tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module github.com/kubeflow/manifests/tests
go 1.13

require (
github.com/PuerkitoBio/purell v1.1.1 // indirect
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
github.com/gogo/protobuf v1.2.2-0.20190730201129-28a6bbf47e48 // indirect
github.com/golang/protobuf v1.3.2 // indirect
Expand Down
3 changes: 1 addition & 2 deletions tests/stacks/kubernetes/application/add-anonymous-user-filter/kustomize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
package add_anonymous_user_filter

import (
"testing"

"github.com/kubeflow/manifests/tests"
"testing"
)

func TestKustomize(t *testing.T) {
Expand Down
5 changes: 4 additions & 1 deletion ...tions/iap-ingress/test_data/expected/networking.k8s.io_v1beta1_ingress_envoy-ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
annotations:
ingress.kubernetes.io/ssl-redirect: "true"
kubernetes.io/ingress.allow-http: "false"
kubernetes.io/ingress.global-static-ip-name: kf-v1-0210-ip
networking.gke.io/managed-certificates: gke-certificate
labels:
Expand All @@ -16,6 +16,9 @@ metadata:
name: envoy-ingress
namespace: istio-system
spec:
backend:
serviceName: istio-ingressgateway
servicePort: 80
rules:
- host: kf-v1-0210.endpoints.jlewi-dev.cloud.goog
http:
Expand Down