Skip to content

Moving central dashboard links to configmap#1394

Merged
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
SachinVarghese:kubeflow-links
Jul 24, 2020
Merged

Moving central dashboard links to configmap#1394
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
SachinVarghese:kubeflow-links

Conversation

@SachinVarghese

@SachinVarghese SachinVarghese commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

Description of your changes:
Related to kubeflow/kubeflow#5147 (To be merged after central dashboard PR merges)

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla Bot added the cla: yes label Jul 17, 2020
@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @SachinVarghese. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SachinVarghese SachinVarghese marked this pull request as ready for review July 17, 2020 21:35
@swiftdiaries

Copy link
Copy Markdown
Member

/ok-to-test

@krishnadurai krishnadurai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@swiftdiaries

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c8f0a4 into kubeflow:master Jul 24, 2020
@HassanOuda

Copy link
Copy Markdown

@swiftdiaries @SachinVarghese Can we have this cherrypicked into v1.1 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants