Automated cherry pick of #1335: added support for registration flow env variable Cherry pick of #1335 on v1.1-branch. #1335: added support for registration flow env variable

[lalithvaka]

No description provided.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[kubeflow-bot]

This change is 

[lalithvaka]

@maganaluis Can you please provide your consent by commenting on these pull request with "@googlebot I consent".

[maganaluis]

@lalithvaka Thank you, I was checking the version of the image tag and it's using vmaster-gf39279c0 which was created prior my PR. We would need this to use vmaster-g1e0cf04b which is the latest image created on June. Could we incorporate that into your PR?

[lalithvaka]

@maganaluis , I followed the cherry pick process by specifying the upstream release name(upstream/v1.1-branch) and the PR number. Beyond that, I don't think we can control or specify which image.

[maganaluis]

@jlewi We need to update the central dashboard image to use the latest tag vmaster-g1e0cf04b, do we need to submit a separate PR and cherry pick that as well? My bad I probably should've commit that on the manifest change.

[jlewi]

Images should be auto-updated and built

1. Was the change to the source code cherry-picked onto the 1.1 branch of kubeflow/kubeflow?
2. Once it is that should trigger an auto-update PR
   https://github.com/kubeflow/kubeflow/pulls?q=is%3Apr+author%3Akubeflow-bot+is%3Aclosed

[maganaluis]

@googlebot I consent

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[krishnadurai]

/lgtm
/approve

[jlewi]

/hold

@lalithvaka Does the image need to be updated before this PR is merged?

[lalithvaka]

Images should be auto-updated and built

1. Was the change to the source code cherry-picked onto the 1.1 branch of kubeflow/kubeflow?
2. Once it is that should trigger an auto-update PR
   https://github.com/kubeflow/kubeflow/pulls?q=is%3Apr+author%3Akubeflow-bot+is%3Aclosed

@jlewi Yes - I have submitted a cherry pick to the source code on kubeflow/kubeflow - pending approval. Can you please help approve that as well?

[jlewi]

@lalithvaka please keep an eye on that PR and check whether the image is auto-rebuilt and then approve the PR before merging this PR.

[lalithvaka]

@jlewi , per @maganaluis this is good to move forward. Can you please unblock this cherry pick to merge? Thank you.

[lalithvaka]

/approve

[lalithvaka]

/assign @yanniszark

[yanniszark]

Image is updated with PR: #1378
/hold cancel
/approve
/lgtm

[lalithvaka]

@maganaluis , not sure what failed here. Can you please check?

[maganaluis]

@lalithvaka Can you revert the latest commit on your fork?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishnadurai, lalithvaka, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yanniszark]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maganaluis]

/retest

[maganaluis]

@lalithvaka Looks good now, no conflicts and all tests passed. Needs the lgtm label again.

[yanniszark]

/lgtm