-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Katib manifests v3 version #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 6 commits into
kubeflow:master
from
andreyvelich:issue-1092-katib-v3-manifest
Apr 27, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
acdefb1
Add v3 Katib package
andreyvelich cad49ce
Generate tests
andreyvelich 795a236
Fix format
andreyvelich fa650b6
Remove Katib from Stacks
andreyvelich 44cf589
Fix Test
andreyvelich 803c1eb
Remove version from all Katib Applications
andreyvelich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: kubeflow | ||
| resources: | ||
| - ../base/katib-configmap.yaml | ||
| - ../base/katib-controller-deployment.yaml | ||
| - ../base/katib-controller-rbac.yaml | ||
| - ../base/katib-controller-secret.yaml | ||
| - ../base/katib-controller-service.yaml | ||
| - ../base/katib-mysql-deployment.yaml | ||
| - ../base/katib-mysql-pvc.yaml | ||
| - ../base/katib-mysql-secret.yaml | ||
| - ../base/katib-mysql-service.yaml | ||
| - ../base/katib-db-manager-deployment.yaml | ||
| - ../base/katib-db-manager-service.yaml | ||
| - ../base/katib-ui-deployment.yaml | ||
| - ../base/katib-ui-rbac.yaml | ||
| - ../base/katib-ui-service.yaml | ||
| - ../base/trial-template-configmap.yaml | ||
| - ../overlays/application/application.yaml | ||
| - ../overlays/istio/katib-ui-virtual-service.yaml | ||
| images: | ||
| - name: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-controller | ||
| newTag: v0.8.0 | ||
| newName: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-controller | ||
| - name: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-db-manager | ||
| newTag: v0.8.0 | ||
| newName: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-db-manager | ||
| - name: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-ui | ||
| newTag: v0.8.0 | ||
| newName: gcr.io/kubeflow-images-public/katib/v1alpha3/katib-ui | ||
| - name: mysql | ||
| newTag: "8" | ||
| newName: mysql | ||
| commonLabels: | ||
| app.kubernetes.io/component: katib | ||
| app.kubernetes.io/instance: katib-controller | ||
| app.kubernetes.io/managed-by: kfctl | ||
| app.kubernetes.io/name: katib-controller | ||
| app.kubernetes.io/part-of: kubeflow | ||
| configurations: | ||
| - params.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| varReference: | ||
| - path: spec/http/route/destination/host | ||
| kind: VirtualService |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: kubeflow | ||
| resources: | ||
| - ../base/experiment-crd.yaml | ||
| - ../base/suggestion-crd.yaml | ||
| - ../base/trial-crd.yaml | ||
| - ../overlays/application/application.yaml | ||
| commonLabels: | ||
| app.kubernetes.io/component: katib | ||
| app.kubernetes.io/instance: katib-crds | ||
| app.kubernetes.io/managed-by: kfctl | ||
| app.kubernetes.io/name: katib-crds | ||
| app.kubernetes.io/part-of: kubeflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So per comment: #1124 (comment)
I think this should be something like
resources:
The resources listed here would then move into the respective packages.
patchesStrategicMerge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, we can use patch here.
What do you think @discordianfish, can you make these changes in #986 PR?
/cc @johnugeorge @gaocegege
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in #986 @discordianfish said he didn't have time to make any additional changes. So maybe @andreyvelich you could just make the changes in this PR? Or a follow on PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for you to settle on one way to do it. But now it's probably better to merge this here first. I can look into a new PR to change this.