Skip to content

Conversation

@tottoto
Copy link
Contributor

@tottoto tottoto commented Jul 28, 2025

Motivation

The Future trait is added to the prelude at Rust 2024.

Solution

Removes the import sentences of the Future trait.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.1%. Comparing base (34d6d05) to head (f62c396).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1799     +/-   ##
=======================================
+ Coverage   75.1%   75.1%   +0.1%     
=======================================
  Files         84      84             
  Lines       7791    7791             
=======================================
+ Hits        5847    5850      +3     
+ Misses      1944    1941      -3     
Files with missing lines Coverage Δ
kube-client/src/api/portforward.rs 0.0% <ø> (ø)
kube-client/src/api/remote_command.rs 41.2% <ø> (ø)
kube-runtime/src/controller/future_hash_map.rs 95.3% <ø> (ø)
kube-runtime/src/controller/mod.rs 30.1% <ø> (ø)
kube-runtime/src/controller/runner.rs 94.3% <ø> (ø)
kube-runtime/src/utils/delayed_init.rs 97.2% <ø> (ø)
kube-runtime/src/utils/mod.rs 63.5% <ø> (ø)
kube-runtime/src/utils/stream_backoff.rs 84.8% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@clux clux added this to the next-major milestone Jul 28, 2025
@clux clux added the changelog-exclude changelog excluded prs label Jul 28, 2025
@clux clux merged commit bfab005 into kube-rs:main Jul 28, 2025
16 of 17 checks passed
@tottoto tottoto deleted the prelude-future branch July 28, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-exclude changelog excluded prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants