Conflicts with NERDTree menu ('m' key)

[techniq]

When vim-signature is installed, I am unable to toggled NERDTree's menu (m key). I tried setting g:SignatureDefaultMappings = 0, but that didn't work.

[kshenoy]

Hey, I need to figure out how to disable the mapping of 'm' specifically in the NERDTree buffer. However, I'm really busy with school now and I don't know when I'll be able to do it.

However, for the moment, you can set g:SignatureMarkLeader to something other than 'm'.

[techniq]

I looked how vim-showmarks did this as I recall them not having the issue (I ran it for a while but didn't like it as well as vim-signature). It appears it has a config variable showmarks_ignore_type to specify which window types to ignore (defaults to 'help' and 'quickfix'). If I check the nerdtree window, it appears to buftype=nofile. Maybe check buftype and return early if it's nofile or one of the others (like help, quickfix, etc).

I don't have a lot of time myself to try to fix and submit a pull request, but if you don't get time in the near future, I'll take a stab at it. Thanks for your reply.

[kshenoy]

Hey, thanks for the tip. I'd come across that when first going through vim-showmarks but didn't feel a need for it so left it out. Anyway, implemented your suggestion and checked in as dev branch. Currently it only checks if buftype=nofile.

Give it a try and let me know if it works properly. Will extend it for help and quickfix etc. if nothing is broken when I get some breathing space ;)

[techniq]

I checked out dev and it fixed Nerdtree. Thanks for making the time to fix it. I'll let you know if I find any other conflicting window types.

[valeriangalliat]

Hi,

The fix introduced in this issue seems to be removed with this commit.

Is there a way to disable vim-signature in NERDTree buffer to avoid having a delay on the m key?

[kshenoy]

Haha, that was almost 2 years ago :D

Anyway, can you give it a try now?

[valeriangalliat]

Awesome! It works now, thanks. :)

[valeriangalliat]

Oh well… when opening, closing, and opening again NERDTree, I have the following error:

Error detected while processing function signature#utils#Maps..<SNR>140_Map:                                                                                                                           
line    8:
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping
E31: No such mapping

Patched it like this, what do you think? (Added silent! before both call.)

diff --git a/plugin/signature.vim b/plugin/signature.vim
index 9d72002..04f0fa4 100644
--- a/plugin/signature.vim
+++ b/plugin/signature.vim
@@ -50,8 +50,8 @@ if has('autocmd')
     autocmd!
     autocmd BufEnter,CmdwinEnter * call signature#sign#Refresh()
     autocmd CursorHold * if g:SignaturePeriodicRefresh | call signature#sign#Refresh() | endif
-    autocmd BufEnter,FileType * if (&filetype ==? 'nerdtree') | call signature#utils#Maps('remove') | endif
-    autocmd BufLeave * if (&filetype ==? 'nerdtree') | call signature#utils#Maps('create') | endif
+    autocmd BufEnter,FileType * if (&filetype ==? 'nerdtree') | silent! call signature#utils#Maps('remove') | endif
+    autocmd BufLeave * if (&filetype ==? 'nerdtree') | silent! call signature#utils#Maps('create') | endif
   augroup END
 endif

[kshenoy]

Oops, forgot a silent! while removing maps. Better to attack the root of the issue. Hopefully, it should be fixed now