fix: Incorrect event name logging when subscribing with :with option#217
Open
qoosuperman wants to merge 1 commit intokrisleech:masterfrom
Open
fix: Incorrect event name logging when subscribing with :with option#217qoosuperman wants to merge 1 commit intokrisleech:masterfrom
qoosuperman wants to merge 1 commit intokrisleech:masterfrom
Conversation
Author
|
@krisleech hello~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215:
Issue Description
when using
LoggerBroadcaster, the message flow is as follows::The
method_to_callargument passed from ObjectRegistration to Broadcasters::LoggerBroadcaster is incorrectly interpreted as the event name in the logging, resulting in incorrect logged information.Solution
This PR ensures that
ObjectRegistration/LoggerBroadcastercorrectly handles theeventandmethod_to_callargumentNote: Although
Broadcasters::SendBroadcaster#broadcastdoes not require theeventargument and only needs themethod_to_callargument, all broadcasters are designed to have a consistent#broadcastmethod interface. Therefore, they should share the same argument structure.