WIP: deepcopy-gen: hack to ensure directory name is set #3342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
requested review from
droot,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
justinsb
changed the title
mortent
approved these changes
Jul 1, 2022
When we use `--input-dirs ./...` deepcopy-gen / defaulter-gen cannot determine the package name, it appears (unless GOPATH is set). Instead use the fully-qualified path as we're using for other generators. `../<dirname>` also works but is not consistent with our other generators.
justinsb
force-pushed
the
nopath_generators
branch
from
3504620 to
7a80814
Compare
|
Let's not merge yet, I'm trying to figure out all the intricacies here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use
--input-dirs ./...deepcopy-gen / defaulter-gen cannotdetermine the package name, it appears (unless GOPATH is set).
Instead use the fully-qualified path as we're using for other
generators.
../<dirname>also works but is not consistent with our othergenerators.