Deprecate any Number constructor

[Bixilon]

Just found some memory hell (I finally switched to upstream glm again from my fork after all the time) and fixed it in 0c90ac2.

I have two ideas:

The first one is removing (or deprecating) all constructors or parameters wich use a Number type. This wraps the primitive in an object (could be quite breaking though).

The second one is (at least for constructors) remove them too and replace them with inlined companion invoke operator functions:

previously:

class Vec1i(val x: Int) {
 
 constructor(x: Number): this(x.i)
}

now (no Number allocation):

class Vec1i(val x: Int) {
 
  companion object {
   inline operator fun Vec1i.Companion.invoke(x: Number) = Vec1i(x.i)
  }
}

What do you think?

[elect86]

What about having a generic Number and a specific type constructor?

Eg: Vec2

constructor(x: Number, y: Number)
constructor(x: Float, y: Float)

[Bixilon]

constructors can not be inlined in kotlin (I don't get why if there is a primary one that is called anyways). That means a Number object is calculated. They need to go.

They can be replaced with the companion invoke method. That will break reflection (is anybody using that) and ABI compatiblity.

I am not sure if there is any other drawback, that is why I want to discuss it. If there is not, we can easily replace all operators that use a specific datatype with inlined Number. This way the library will get a lot smaller and code gets deduplicated.

(I am just thinking about switching away in my project from glm, because I don't need most features)