Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

feat(galleryItem): image orientation #916

Merged
yangwao merged 10 commits into from
Oct 20, 2021
Merged

feat(galleryItem): image orientation #916

yangwao merged 10 commits into from
Oct 20, 2021

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 19, 2021 •
edited
Loading

#819 related

Orientation is quicker without el.onLeave()
Binding Event on window instead of element

all credit goes to prachi00

@yangwao
Copy link
Member

yangwao commented Oct 19, 2021

What's that for?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 20, 2021 •
edited
Loading

What's that for?

Testing purpose.

What changed

  • Perspective works on full window like in codepen example.
  • Fixed orientation speed on desktop, see preview.

@yangwao
Copy link
Member

yangwao commented Oct 20, 2021

So we can merge it?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 20, 2021

So we can merge it?

I think so, if preview is ok.
Note: currently, we cannot disable motion on GalleryItem

@yangwao yangwao mentioned this pull request Oct 20, 2021
Closed
@yangwao
Copy link
Member

yangwao commented Oct 20, 2021

wow! let it fly

@yangwao yangwao merged commit 428c00d into kodadot:main Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roiLeo @yangwao @prachi00