Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 12, 2021

SearchBar component looks a bit weird on collection page.
Maybe we need to update design/blocks or create an uniq search component for collection.
I would like to try to have filter on the left (replace with icon) & searbar at the center.

PR type

  • Feature

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

What's new? (may be part of changelog)

Screenshot

Screenshot 2021-10-12 at 10-53-37 KusamaCow Collection

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

I would swap search with sort queries & buy now.
Reasoning, people looking which to buy based on predefined things there, like which are available and by other sort queries.

uniq search component for collection.

I see, I'd vote for it probably, we can duplicate it later for one component:)

image

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

Uwaga! 😄 Opozorilo

Screen.Recording.2021-10-12.at.12.21.15.mov

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 12, 2021

Uwaga! 😄 Opozorilo
Screen.Recording.2021-10-12.at.12.21.15.mov

Looks like a new feature to me 😄

I see, I'd vote for it probably, we can duplicate it later for one component:)

Proposal UI

current

Screenshot 2021-10-12 at 14-05-07 Happy Alpaca

with filter icon left

Screenshot 2021-10-12 at 14-01-23 KusamaCow Collection

without toggle

Screenshot 2021-10-12 at 14-00-49 KusamaCow Collection

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

Let's use with filter icon left and add buy now to the end, right next end of Search field?

@vikiival
Copy link
Member

I miss pagination there but I would vote for 2nd (+ add 'filter' label for non-technical users)

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 12, 2021

Pushed new content with a new copy of SearchBar component but for collection

Screeenshot

Screenshot 2021-10-12 at 14-33-16 Happy Alpaca

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

how it would looks like with emojis like 🛒 or 🛍 ? Just curious, just want to have some lightweight
Or checking fontawesome,
cart-shopping-fast https://fontawesome.com/v6.0/icons?q=shop&s=solid%2Cbrands

image

OR let's add BUY NOW with all caps and we are done?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 12, 2021

how it would looks like with emojis like 🛒 or 🛍 ? Just curious, just want to have some lightweight Or checking fontawesome, cart-shopping-fast https://fontawesome.com/v6.0/icons?q=shop&s=solid%2Cbrands

image

Your icon is only avaible on FontAwesome 6, we're on FontAwesome 5 right now.
Here is some example you ask.
Screenshot 2021-10-12 at 14-43-44 Happy Alpaca
Screenshot 2021-10-12 at 14-44-07 Happy Alpaca
Screenshot 2021-10-12 at 14-44-24 Happy Alpaca

edit: could be misleading to show shopping-cart on a filter button

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

how it would looks like with emojis like 🛒 or 🛍 ? Just curious, just want to have some lightweight Or checking fontawesome, cart-shopping-fast https://fontawesome.com/v6.0/icons?q=shop&s=solid%2Cbrands
image

Your icon is only avaible on FontAwesome 6, we're on FontAwesome 5 right now. Here is some example you ask. Screenshot 2021-10-12 at 14-43-44 Happy Alpaca Screenshot 2021-10-12 at 14-44-07 Happy Alpaca Screenshot 2021-10-12 at 14-44-24 Happy Alpaca

edit: could be misleading to show shopping-cart on a filter button

filter is okay with that pipe.

I thought for BUY NOW 😄 - v5.15 maybe shopping-cart https://fontawesome.com/v5.15/icons/shopping-cart?style=solid ?

@yangwao
Copy link
Member

yangwao commented Oct 12, 2021

I think let's make buy now with CAPS BUY NOW and basically that's it now, it's etchy scratchy but fn is there, we should get some designer who will help lay out components to not be that random like on cocaine

@yangwao
Copy link
Member

yangwao commented Oct 13, 2021

Uwaga! 😄 Opozorilo

Screen.Recording.2021-10-12.at.12.21.15.mov

We solve it later I guess? Can open an issue and let this fly before today's sub0 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants