Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@vikiival
Copy link
Member

@vikiival vikiival commented Oct 7, 2021

  • Created basic image component
  • Kudos to roiLeo for css hacks
  • Forgot single quote

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile
  • Are there any edge cases? Name if any

Screenshot 2021-10-07 at 10 48 59

@vikiival vikiival added the UX first Improvement for UX label Oct 7, 2021
@vikiival vikiival self-assigned this Oct 7, 2021
@vikiival vikiival requested a review from roiLeo October 7, 2021 09:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

You're Pull Request scored a 0.05405405405405406 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Gif

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spooky season incoming

Weird, looks like all this rules can now be removed

Co-authored-by: roiLeo <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Gif

@vikiival
Copy link
Member Author

vikiival commented Oct 7, 2021

🚢

@vikiival vikiival merged commit d537e8e into main Oct 7, 2021
@vikiival vikiival deleted the basic-image branch October 7, 2021 10:32
@vikiival vikiival restored the basic-image branch October 7, 2021 10:32
@vikiival vikiival deleted the basic-image branch October 7, 2021 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

UX first Improvement for UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants