Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it on mobile and everything works
  • I found edge cases

What's new? (may be part of changelog)

If issue had bounty label ($,$$,$$$)

Community participation

Screenshot

  • Whenever my fix has changed something on UI, a screenshot for others, is more than welcome

Screenshot 2021-09-23 at 7 27 53 PM

@yangwao yangwao requested review from roiLeo and vikiival September 23, 2021 14:36
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing that bothers me is that the Sharing component is not clickable on the inside

edit: screenshot with pink clickable zone to show what i mean
Screenshot 2021-09-23 at 16-37-49 Second Rate Clowns
.

@yangwao
Copy link
Member

yangwao commented Sep 23, 2021

I would suggest changing to the same height as its icons in this same row? Probably could be the same height as the Gift button?

image

@yangwao
Copy link
Member

yangwao commented Sep 23, 2021

LGTM, the only thing that bothers me is that the Sharing component is not clickable on the inside

Yes, from a mobile perspective and mobile lighthouse report, I guess button should be clickable all surface

@prachi00
Copy link
Member Author

@yangwao @roiLeo Have done the 2 changes mentioned.

@yangwao yangwao merged commit 117161d into kodadot:main Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make unified button for sharing and linking

3 participants