This repository was archived by the owner on Dec 5, 2025. It is now read-only.
My cup of mokka #773
Merged
My cup of mokka #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
You're Pull Request scored a 0.11764705882352941 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR: |
Member
Author
|
@JKrupinski If you will find a way how to run jest with our setup I would be happy to drop a bounty. |
Contributor
|
|
Member
|
Good starter I guess |
yangwao
approved these changes
Sep 22, 2021
roiLeo
reviewed
Sep 22, 2021
Contributor
roiLeo
left a comment
roiLeo
left a comment
There was a problem hiding this comment.
Will this be affecting bundle size and building time ?
Contributor
check #775 probably it still needs some improvements but looks like it works |
Contributor
|
|
Member
Author
It should not change the bunde size |
Member
|
I guess draft? |
Contributor
|
|
# Conflicts: # yarn.lock
Contributor
|
|
Contributor
|
|
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!
Added mocha + chai for unit testing.
Closing #707
PR type