Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

@prachi00 prachi00 commented Sep 1, 2021

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new? (maybe part of changelog)

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU

Community participation

Screenshot

  • [x

Screenshot 2021-09-01 at 10 44 17 PM

] Whenever your fix will change **something** on UI, a screenshot is more than welcome

@roiLeo
Copy link
Contributor

roiLeo commented Sep 2, 2021

Should we see the button when the user is not logged in? Is this a normal behavior? I thought the "unlist" button was only visible for the owner.

@vikiival
Copy link
Member

vikiival commented Sep 2, 2021

Should we see the button when the user is not logged in? Is this a normal behavior? I thought the "unlist" button was only visible for the owner.

Yup @roiLeo is right.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlist should be visible only if currentOwner === accountId and nft.price > 0

@prachi00
Copy link
Member Author

prachi00 commented Sep 2, 2021

Unlist should be visible only if currentOwner === accountId and nft.price > 0

@roiLeo @vikiival Have added the check for this, seems to be working fine now.

@prachi00 prachi00 requested a review from vikiival September 2, 2021 10:38
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to unlist NFT when is on sale

4 participants