Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@gdev1001
Copy link
Contributor

@gdev1001 gdev1001 commented Aug 24, 2021

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new? (maybe part of changelog)

  • closes When user doesn't have extension and clicks on [log-in] button #615 - <Added - check polkadot.js extension on the login page (if you've installed polkadot.js in your browser then when you click the 'Login' button, they should be showing a dropdown to login but if you didn't install polkadot.js then should be showing the dropdown to install polkadot.js )>

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: <Kusama_address>

Community participation

Screenshot

Selection_239

@yangwao
Copy link
Member

yangwao commented Aug 24, 2021

which issues is closed by this? can you update it in PR description please? Can you provide screenshot in the PR description as well?

@yangwao yangwao mentioned this pull request Aug 25, 2021
Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some reviews

<template v-if="isExtension && (changeAccount || !account)">
<b-dropdown-item has-link aria-role="menuitem">
<a href="https://polkadot.js.org/extension/" target="_blank" class="is-flex is-align-items-center pl-3">
Inspiration extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to "Install desktop wallet extension"

</b-dropdown-item>
<b-dropdown-item has-link aria-role="menuitem">
<a href="https://chrome.google.com/webstore/detail/polkadot%7Bjs%7D-extension/mopnmbcafieddcagagdcbnhejhlodfdd" target="_blank" class="is-flex is-align-items-center pl-3">
Link to chrome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change it to "Install Chrome Wallet Extension"

</b-dropdown-item>
<b-dropdown-item has-link aria-role="menuitem">
<a href="https://addons.mozilla.org/en-US/firefox/addon/polkadot-js-extension/" target="_blank" class="is-flex is-align-items-center pl-3">
Link to firefox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change it to "Install Firefox Wallet Extension"

@yangwao
Copy link
Member

yangwao commented Aug 25, 2021

Awesome!
Screenshot 2021-08-25 at 15 47 03

@yangwao yangwao merged commit 6cd8858 into kodadot:main Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When user doesn't have extension and clicks on [log-in] button

3 participants