Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 24, 2021

Some small refactoring over here

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Refactoring

Screenshot

compare with deploy preview

@yangwao
Copy link
Member

yangwao commented Aug 24, 2021

okay this is nice catch https://web.dev/external-anchors-use-rel-noopener/
probably could be fixed elsewhere?

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 24, 2021

okay this is nice catch https://web.dev/external-anchors-use-rel-noopener/
probably could be fixed elsewhere?

What do you mean ? in a new branch ?

@yangwao
Copy link
Member

yangwao commented Aug 24, 2021

okay this is nice catch https://web.dev/external-anchors-use-rel-noopener/
probably could be fixed elsewhere?

What do you mean ? in a new branch ?

I mean, like in all KodaDot app? Yes, it could be separate PR I guess if so?

@yangwao yangwao merged commit 79f6c00 into kodadot:main Aug 24, 2021
@roiLeo roiLeo deleted the fix/gallery-item/components branch August 24, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants