Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@chris-sab
Copy link

Right now we are showing accounts that have at least some RMRK went through their account.
Would be good to add a toggle to show only accounts with identity in /spotlight to filter no-names and scammers.

@chris-sab
Copy link
Author

@vikiival @yangwao
I think we need to modify basing on switch filter component flag to filter data in that table? I hope you would list more detail requirement. Please check my implementation.

import { spotlightAggQuery } from '../rmrk/Gallery/Search/query';
import TransactionMixin from '@/utils/mixins/txMixin';
import { denyList } from '@/constants';
import { Component, Prop, Vue, Mixins, Watch } from "vue-property-decorator";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a single quote.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done it.

this.isLoading = false;
}
@Watch("isShowIdentity")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be done by @input event

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done it.

overflow: hidden;
text-overflow: ellipsis;
}
.short-identity__table {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces

@yangwao
Copy link
Member

yangwao commented Aug 18, 2021

@chris-saburo can you use the PR template, please?

@yangwao
Copy link
Member

yangwao commented Aug 18, 2021

Seems doesn't work?

image

@yangwao yangwao changed the title Show users with identity in spotlight WIP: Show users with identity in spotlight Aug 18, 2021
@yangwao yangwao marked this pull request as draft August 18, 2021 09:32
@chris-sab
Copy link
Author

chris-sab commented Aug 18, 2021

@yangwao @vikiival please look at this:

image

@yangwao yangwao marked this pull request as ready for review August 19, 2021 08:06
@yangwao
Copy link
Member

yangwao commented Aug 19, 2021

Seems PR doesn't load for me, check error? On production, it works tho https://nft.kodadot.xyz/spotlight
image

@yangwao
Copy link
Member

yangwao commented Aug 21, 2021

When I turn off identity I've got empty list
image

Why pagination doesn't work?
image

@chris-sab
Copy link
Author

chris-sab commented Aug 21, 2021

When I turn off identity I've got empty list
image

Why pagination doesn't work?
image

I think I did implement the filter logic but it didn't work out weirdly so I hope I would like to discuss with you or Vikil to find the reason. In the logics, I think there might be not any issues but it didn't work out. @yangwao

@yangwao
Copy link
Member

yangwao commented Aug 23, 2021

Closed in #616

@yangwao yangwao closed this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants