Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 8, 2021

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

PR type

  • Bugfix
  • Feature
  • Refactoring

Changes

  • fix semantic collection by adding h1
  • fix galleryCard image alternative text
  • add meta og:url
  • add meta twitter:card
  • add subscan svg alternative text

@roiLeo roiLeo changed the title feat(collection): improve SEO DRAFT: feat(collection): improve SEO Jul 8, 2021
@roiLeo roiLeo marked this pull request as draft July 8, 2021 12:58
@roiLeo roiLeo marked this pull request as ready for review July 8, 2021 14:30
@yangwao
Copy link
Member

yangwao commented Jul 8, 2021

Do you refer to this one #118 ?

Looks the same to me here
image

@roiLeo roiLeo changed the title DRAFT: feat(collection): improve SEO feat(collection): improve SEO Jul 8, 2021
@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 8, 2021

This is not #118 related, I've added a comment in issue for telegram documentation.
This PR fix semantic issue (h1), add open graph basic Metadata (og:url) and preview twitter card for large images.

@yangwao yangwao merged commit 3700189 into kodadot:main Jul 9, 2021
@roiLeo roiLeo deleted the feature/collection/seo branch August 23, 2021 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants