Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 6, 2021

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

PR type

  • Feature

Screenshot

Screenshot 2021-07-06 at 15-40-58 Singularity Bits #030

I don't know if it's a good way to duplicate "Identity" class.
Let me know if I have to import it instead.

@roiLeo roiLeo marked this pull request as draft July 6, 2021 13:50
@vikiival
Copy link
Member

vikiival commented Jul 6, 2021

@roiLeo UI is really nice !

just some things:
Afaik ProfileLink is composed of identity and link to subscan
If I were you I would add new boolean prop like showTwitter or withTwitter which would show the tw handle

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 7, 2021

Screenshots

GalleryItem

Screenshot 2021-07-07 at 11-27-19 Evil Saber

CollectionItem

Screenshot 2021-07-07 at 11-28-02 Spunkbits

@roiLeo roiLeo marked this pull request as ready for review July 7, 2021 09:32
@yangwao
Copy link
Member

yangwao commented Jul 7, 2021

LGTM

@yangwao yangwao merged commit bacbbad into kodadot:main Jul 7, 2021
@roiLeo roiLeo deleted the feature/identity/twitter branch August 25, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Twitter from on-chain Identity to NFT detail

3 participants