Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@vikiival
Copy link
Member

@vikiival vikiival commented Jun 28, 2021

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any erros or warnings
  • Merged recent default branch -- main and I've no conflicts
  • Didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new? (may be part of changelog)

  • closes #<issue_number> - <Brief_description_how_you_fixed_it>

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: <Kusama_address>

Community participation

Screenshot

  • Whenever your fix will change something on UI, a screenshot is more than welcome

@vikiival vikiival added enhancement New feature or request A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama labels Jun 28, 2021
@vikiival vikiival self-assigned this Jun 28, 2021
@vikiival vikiival requested a review from yangwao June 28, 2021 13:41
@github-actions
Copy link
Contributor

You're Pull Request scored a -0.030303030303030304 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

Gif

@vikiival vikiival marked this pull request as draft June 29, 2021 09:00
@vikiival vikiival marked this pull request as ready for review June 29, 2021 11:17
@github-actions
Copy link
Contributor

Gif

@yangwao yangwao merged commit b0fe7d1 into main Jun 29, 2021
@vikiival vikiival deleted the profile-issued-owned branch June 29, 2021 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants