#3540 Offer burned nfts #3575

prachi00 · 2022-07-27T01:03:37Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR closes Offer burned nfts #3540
Requires deployment <rubick/magick_issue>
<brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address:
Payout

Community participation

Are you at KodaDot Discord?

Screenshot

My fix has changed something on UI; a screenshot is best to understand changes for others.

kodabot · 2022-07-27T01:03:41Z

WARNING @prachi00 PR for issue #3540 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3540

netlify · 2022-07-27T01:03:41Z

❌ Deploy Preview for koda-nuxt failed.

Name	Link
🔨 Latest commit	`ee3cbed`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62eaf8179ac69a0009ad8caa

roiLeo

why do we need to show burned content?
If it's burned, the offer shouldn't exist anymore

yangwao · 2022-07-27T11:37:03Z

why do we need to show burned content?
If it's burned, the offer shouldn't exist anymore

the issue with bsx implementation is that if I'm not mistaken, either if the offer is expired or on burned nft, your stake is not being unlocked.

thus maybe #3401 would be a more excellent way to go, but this way to have it here till then is also good, maybe later removed. As currently there is no other way to see your offers on burned nfts tho.

petersopko · 2022-07-29T09:17:02Z

@prachi00 I'm having some trouble testing this, but as @yangwao mentioned, we're going to move forward with this as (at least) temporary solution, so please:

let's merge latest main, balance input was redesigned (currently I can't place offers and therefore cannot test for burned NFTs with my offers)
resolve conflicts pls

thank youu 🚀

prachi00 · 2022-07-31T00:26:39Z

@prachi00 I'm having some trouble testing this, but as @yangwao mentioned, we're going to move forward with this as (at least) temporary solution, so please:

let's merge latest main, balance input was redesigned (currently I can't place offers and therefore cannot test for burned NFTs with my offers)

resolve conflicts pls

thank youu 🚀

donee

petersopko

wfm

petersopko · 2022-08-03T06:36:04Z

@Jarsen136 hey, since @roiLeo is at holiday, can you check code in this one please? :)

Jarsen136

code lgtm

components/bsx/Offer/OffersUserTable.vue

prachi00 · 2022-08-03T22:53:25Z

pay 50 usd

yangwao · 2022-08-03T22:53:35Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 62.03 USD/KSM ~ 0.806 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x562377dd5ebfcde7fc3aed7f2027d3de8b0c93fa2862781edc62396660de5804

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

petersopko · 2022-08-04T10:29:01Z

@prachi00 after you've merged and closed this one, I see that the deploy didn't happen, was every conflict resolved etc?

I'm currently facing an issue, where I cannot withdraw the offer from burned the NFT (filtering works, action button doesn't) I saw that it was working for me before, but perhaps, there was something wrong ? Can you check please and reopen if there's some adjustment needed?

prachi00 · 2022-08-04T18:58:14Z

@prachi00 after you've merged and closed this one, I see that the deploy didn't happen, was every conflict resolved etc?

I'm currently facing an issue, where I cannot withdraw the offer from burned the NFT (filtering works, action button doesn't) I saw that it was working for me before, but perhaps, there was something wrong ? Can you check please and reopen if there's some adjustment needed?

I'll check

prachi00 · 2022-08-05T00:14:41Z

@prachi00 after you've merged and closed this one, I see that the deploy didn't happen, was every conflict resolved etc?

I'm currently facing an issue, where I cannot withdraw the offer from burned the NFT (filtering works, action button doesn't) I saw that it was working for me before, but perhaps, there was something wrong ? Can you check please and reopen if there's some adjustment needed?

@petersopko I dont think its caused by this but we can revert it and check if it works fine then for you?

petersopko · 2022-08-05T10:24:52Z

@prachi00 you're right, this is not problem of this PR, sorry

petersopko · 2022-08-05T11:07:57Z

galacticcouncil/Basilisk-node#543

#3540 Offer burned nfts

7e09897

prachi00 requested review from a team as code owners July 27, 2022 01:03

prachi00 requested review from damskyftw and roiLeo and removed request for a team July 27, 2022 01:03

prachi00 requested a review from petersopko July 27, 2022 01:04

roiLeo reviewed Jul 27, 2022

View reviewed changes

petersopko mentioned this pull request Jul 27, 2022

Burning NFT should cancel Offers #3584

Closed

conflcits remove

652f492

petersopko approved these changes Jul 31, 2022

View reviewed changes

prachi00 requested a review from roiLeo August 2, 2022 22:22

Merge branch 'main' into feat-burned-toggle

d9de179

petersopko requested review from Jarsen136 and removed request for roiLeo August 3, 2022 06:35

Merge branch 'main' into feat-burned-toggle

b9feeb0

Jarsen136 approved these changes Aug 3, 2022

View reviewed changes

Jarsen136 reviewed Aug 3, 2022

View reviewed changes

components/bsx/Offer/OffersUserTable.vue Outdated Show resolved Hide resolved

prachi00 and others added 2 commits August 3, 2022 15:34

remove unused

4295de0

Merge branch 'main' into feat-burned-toggle

ee3cbed

prachi00 merged commit e823c2f into main Aug 3, 2022

prachi00 deleted the feat-burned-toggle branch August 3, 2022 22:53

yangwao added the paid pull-request has been paid label Aug 3, 2022

Uh oh!

#3540 Offer burned nfts #3575

#3540 Offer burned nfts #3575

Uh oh!

Conversation

prachi00 commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

Uh oh!

kodabot commented Jul 27, 2022

Uh oh!

netlify bot commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for koda-nuxt failed.

Uh oh!

roiLeo left a comment

Choose a reason for hiding this comment

Uh oh!

yangwao commented Jul 27, 2022

Uh oh!

petersopko commented Jul 29, 2022

Uh oh!

prachi00 commented Jul 31, 2022

Uh oh!

petersopko left a comment

Choose a reason for hiding this comment

Uh oh!

petersopko commented Aug 3, 2022

Uh oh!

Jarsen136 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prachi00 commented Aug 3, 2022

Uh oh!

yangwao commented Aug 3, 2022

Uh oh!

petersopko commented Aug 4, 2022

Uh oh!

prachi00 commented Aug 4, 2022

Uh oh!

prachi00 commented Aug 5, 2022

Uh oh!

petersopko commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petersopko commented Aug 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

prachi00 commented Jul 27, 2022 •

edited

Loading

netlify bot commented Jul 27, 2022 •

edited

Loading

petersopko commented Aug 5, 2022 •

edited

Loading