Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

🌕 Integration with Moonsama v0 #3340

Merged
yangwao merged 19 commits into from
Jul 7, 2022
Merged

🌕 Integration with Moonsama v0 #3340

yangwao merged 19 commits into from
Jul 7, 2022

Conversation

@vikiival
Copy link
Member

@vikiival vikiival commented Jul 6, 2022

  • ⚡ moonsama url should be present
  • 🎉 copypasted moonsama from bsx
  • ⚡ expect that default indexer is subsquid
  • 🔧 moonsama indexer config
  • 🔝 moonsama detail :)
  • 🐛 metadata can override id
  • ⚡ added click
  • 🎉 copy-paste moonsama here
  • ⚡ correct build platform for moonsama
  • ⚰️ removed available actions
  • ⚡ formatter to evm addr
  • ⚡ utiiiiils
  • ⚡ create only visible based on the configuration

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Known problems:

  • Identicon does not work
  • Auth shows Address in polkadot format (Account32) -> should be ETH addr (Account20) //there is util ready for that
  • Collection meta are not visible (my bad, forgot to index them)
  • ERC-1155 are not there yet (Index properly single transfers for ERC-1155 click#5)
  • Bvlck collection has strange ABI (Index BLVCK click#6)
  • If you found something else just open issue.
  • Code is copy-paste from basilisk so if you spot some mismatch pls comment

@vikiival vikiival requested a review from a team as a code owner July 6, 2022 11:11
@vikiival vikiival requested review from prachi00 and removed request for a team July 6, 2022 11:11
@netlify
Copy link

netlify bot commented Jul 6, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c1a74c8
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62c69963e798af0008f2eebb
😎 Deploy Preview https://deploy-preview-3340--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vikiival vikiival requested a review from yangwao July 6, 2022 11:11
@roiLeo
Copy link
Contributor

roiLeo commented Jul 6, 2022

Evm (Metamask) wallet integration is more or less ready if you want to test it out

@vikiival
Copy link
Member Author

vikiival commented Jul 6, 2022 •
edited
Loading

Evm (Metamask) wallet integration is more or less ready if you want to test it out

Woah sure!
but read only version for now would be good

@vikiival vikiival requested a review from roiLeo July 6, 2022 11:19
@yangwao yangwao requested a review from petersopko July 6, 2022 11:22
roiLeo
roiLeo reviewed Jul 6, 2022
View reviewed changes
utils/config/permision.config.ts
@@ -0,0 +1,15 @@
import { Prefix } from './indexer.config'
Copy link
Contributor

@roiLeo roiLeo Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this file will be used for?

Copy link
Member Author

@vikiival vikiival Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(permision or indexer).config ?

Copy link
Member Author

@vikiival vikiival Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But permision.config -> should mark some features that are not available on some chains -> e.g create on moonsama

indexer.config -> {
one configuration to correctly handle indexers
}

Copy link
Contributor

@roiLeo roiLeo Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both 😃

@yangwao
Copy link
Member

yangwao commented Jul 6, 2022

Seems pagination and infinity scrolling is broken 👀

but manually adding pages works

image

@yangwao yangwao mentioned this pull request Jul 6, 2022
Closed
This was linked to issues Jul 7, 2022
Add support for Moonsama to endpoint chain selector #3177
Closed
Spin up EVM SubSquid for Moonsama #3176
Closed
@yangwao yangwao mentioned this pull request Jul 7, 2022
Closed
1 task
@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

https://deploy-preview-3340--koda-nuxt.netlify.app/moonsama/u/0x495E889d1A6cEB447a57dcc1C68410299392380c?tab=sold

I guess hence we have quite long work to do, so let's continue through

image

@yangwao yangwao merged commit d09d325 into main Jul 7, 2022
@yangwao yangwao deleted the wen-moon branch July 7, 2022 13:00
@roiLeo
Copy link
Contributor

roiLeo commented Jul 7, 2022

artworks-000528979299-op8qu5-t500x500

@vikiival vikiival mentioned this pull request Jul 9, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prachi00 prachi00 Awaiting requested review from prachi00 prachi00 is a code owner automatically assigned from kodadot/code-review-guild

@yangwao yangwao Awaiting requested review from yangwao

@petersopko petersopko Awaiting requested review from petersopko

1 more reviewer

@roiLeo roiLeo roiLeo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Moonsama to endpoint chain selector Spin up EVM SubSquid for Moonsama

4 participants

@vikiival @roiLeo @yangwao