-
-
Notifications
You must be signed in to change notification settings - Fork 365
Gallery card update #289
Gallery card update #289
Conversation
|
Siiick! Like it! |
|
@AndreyGrin NFT has already field price field
However, if you want to be make the consistent put there something like |
Yeah It wold be perfect to leave it visible (you have no hover on mobile) |
|
@AndreyGrin I am not sure if it's because of this pr but detail seems a bit broken |
|
@vikiival last commit should prevent any impact on other pages |
|
Guys, if you confirm design implementation, I will update code to support |
price and emoteCount labels shown when model has them
nft item animation tweak
|
|
|
Hey, can you re-check one more time? There was recent merge to the |
|
oh found something weird semi-state. |
Hey by this price should be there? |
Screen.Recording.2021-04-15.at.13.23.41.movin order to get rid of the animation glitch but to keep card structure same, applied |
|
Hey, @yangwao! Any news on the PR? |
Hey @AndreyGrin please make sure that you are using correct prices for NFTs (there is field |
AndreyGrin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikiival check comments to the code. I believe I use correct not props
|
@vikiival changed Price to use component |
|
Hey checking @AndreyGrin We would like close this so it can go to our 7k changelog |
|
We didn't project price from query. Pushed the fixed. @yangwao /@AndreyGrin I would maybe remove USD value. But it's personal prefference |
|
@yangwao what exactly? Unit? |
|
let's merge it! gonna process payout! |





Hey, added requested styles (issue #230).
This is currently mock Price and EMOTE. Is it possible to add from back-end next params:
hasPrice,priceand number for EMOTE (this is amount of likes or so?). Implemented without https://vuesax.com/docs/components/Card.html#default. Check plz styles and let me know what do you think. I've added zoom animation for video previews as well to be consistent.