Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@AndreyGrin
Copy link
Contributor

Hey, added requested styles (issue #230).
This is currently mock Price and EMOTE. Is it possible to add from back-end next params: hasPrice, price and number for EMOTE (this is amount of likes or so?). Implemented without https://vuesax.com/docs/components/Card.html#default. Check plz styles and let me know what do you think. I've added zoom animation for video previews as well to be consistent.

@yangwao
Copy link
Member

yangwao commented Apr 12, 2021

Siiick! Like it!
I mean just manage to hide the tittle so it could roll over picture once there is hover.
For hasPrice, price cc @vikiival

@vikiival
Copy link
Member

vikiival commented Apr 12, 2021

@AndreyGrin NFT has already field price field

hasPrice why ?

number for EMOTE
due to current architecture it's a bit complicated but we are working on migration

However, if you want to be make the consistent put there something like emoteCount field I will update it later

@AndreyGrin
Copy link
Contributor Author

@vikiival hasPrice used on ntf-item page but actually, just price will be enough.
@yangwao changed animation. Do you consider mobile version as well? For mobile, I think, it better to leave NFT title visible.

@vikiival
Copy link
Member

For mobile, I think, it better to leave NFT title visible.

Yeah It wold be perfect to leave it visible (you have no hover on mobile)

@vikiival
Copy link
Member

@AndreyGrin I am not sure if it's because of this pr but detail seems a bit broken

@AndreyGrin
Copy link
Contributor Author

@vikiival last commit should prevent any impact on other pages

@AndreyGrin
Copy link
Contributor Author

AndreyGrin commented Apr 13, 2021

Guys, if you confirm design implementation, I will update code to support price and emoteCount params but it will make labels disappear until yours back-end will add it's part. Please confirm @yangwao

price and emoteCount labels shown when model has them
@yangwao
Copy link
Member

yangwao commented Apr 14, 2021

Hey checking in.

Seems the search is gone?

image

Meanwhile please fetch recent main into your PR to avoid some conflicts in the merge.

nft item animation tweak
@AndreyGrin
Copy link
Contributor Author

main was up to date. Fixed styles and added a bit cleaner animation for sliding-up not title.

@yangwao
Copy link
Member

yangwao commented Apr 15, 2021

Hey, can you re-check one more time? There was recent merge to the main, where you should see sort-filter in search d7eaa80

@yangwao
Copy link
Member

yangwao commented Apr 15, 2021

@yangwao yangwao mentioned this pull request Apr 15, 2021
@yangwao
Copy link
Member

yangwao commented Apr 15, 2021

@AndreyGrin NFT has already field price field

hasPrice why ?

number for EMOTE
due to current architecture it's a bit complicated but we are working on migration

However, if you want to be make the consistent put there something like emoteCount field I will update it later

Hey by this price should be there?
@vikiival will add emoteCount, so you can prepare it to be ready :)

@AndreyGrin
Copy link
Contributor Author

Screen.Recording.2021-04-15.at.13.23.41.mov

in order to get rid of the animation glitch but to keep card structure same, applied overflow:hidden for the card in the gallery, but had to change animation for labels to show them in full.

@AndreyGrin
Copy link
Contributor Author

Hey, @yangwao! Any news on the PR?

@vikiival
Copy link
Member

Hey, @yangwao! Any news on the PR?

Hey @AndreyGrin please make sure that you are using correct prices for NFTs (there is field price on nft) and also conditionally render the emoteCount

Copy link
Contributor Author

@AndreyGrin AndreyGrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikiival check comments to the code. I believe I use correct not props

@AndreyGrin
Copy link
Contributor Author

@vikiival changed Price to use component

@yangwao
Copy link
Member

yangwao commented Apr 20, 2021

Hey checking @AndreyGrin
I don't see any price here on this NFT on gallery view
https://deploy-preview-289--nftkodadot.netlify.app/rmrk/gallery
image

We would like close this so it can go to our 7k changelog

@vikiival
Copy link
Member

We didn't project price from query. Pushed the fixed.

@yangwao /@AndreyGrin I would maybe remove USD value. But it's personal prefference

Screenshot 2021-04-20 at 13 16 42

@yangwao
Copy link
Member

yangwao commented Apr 20, 2021

Yeah, checking on rarible.
USD -> $ ?

This is from item detail.
image
But generally they strip it from gallery view.

I would remove it as well and leave it only for item detail

@yangwao
Copy link
Member

yangwao commented Apr 20, 2021

huh wha's this 🗡️ 🥶
ok cant reproduce, seems some local glitch
image

@AndreyGrin
Copy link
Contributor Author

@yangwao what exactly? Unit?

@yangwao
Copy link
Member

yangwao commented Apr 20, 2021

let's merge it! gonna process payout!
I mean, if you @AndreyGrin are interested and be add value to the KodaDot NFT gallery,
I'm inviting you to KodaDot:Anteriors (Frontend stuff) channel https://t.me/joinchat/eyLAW64RKsNlZjVk - link expires in day

@yangwao yangwao merged commit 2a0f6f5 into kodadot:main Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants