Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@riton
Copy link
Contributor

@riton riton commented Apr 2, 2021

This P.R fixes #24

Markdown rendering is done using the already imported markdown-it-vue dependency.

@riton
Copy link
Contributor Author

riton commented Apr 2, 2021

I wasn't able to find the "Ready for review" template described in CONTRIBUTING.md.

If anything is missing, just ask and I'll modify the P.R description.

@riton
Copy link
Contributor Author

riton commented Apr 2, 2021

Damn, sorry, I've just missed my editor ⚠️ Big TypeScript Warning message , I'm working on it.

@riton riton force-pushed the feature/markdown_render branch from 46ae936 to 8c984a0 Compare April 2, 2021 17:49
* Fixes kodadot#24
* Rely on the already imported markdown-it-vue dependency
@riton riton force-pushed the feature/markdown_render branch from 8c984a0 to 62909da Compare April 2, 2021 17:53
@riton
Copy link
Contributor Author

riton commented Apr 2, 2021

I'm a little confused here 😅 Everything was already done 😄

I must have misunderstood what #24 was about or what you were expecting.

I'm gonna wait for your comments about this.

@yangwao
Copy link
Member

yangwao commented Apr 4, 2021

I recall we had some problems with it, can check on that.
Oh I know, there were two markdown approaches.
We've started adding it to description but then we've figured out other plugin just simply doesn't work for what we want and we would like avoid having bundle bigger for something we don't need and keep it small.
#101

https://github.com/kodadot/nft-gallery/tree/i18n-markdown check this one?

@riton
Copy link
Contributor Author

riton commented Apr 5, 2021

Hi @yangwao

So if I understand well markdown-it-vue is kinda too big for you and you'd like to use another markdown renderer ?

@yangwao
Copy link
Member

yangwao commented Apr 6, 2021

@riton exactly! As even now our bundle is quite huge and we want to be lean here if possible as we don't have any SSR to accelerate the first load tho and hydrate later.

Well, "another", I've already found one good and started that one have some template where you can assemble i18n fashion strings and links as our faq are now quite a big blocker in this, I guess if you could work out on that #101 that would be big help for us.

Can you join our Anteriors chat for faster coordination? Whenever you will have question https://t.me/joinchat/PBLZLs6SFcI3ZmFk

@yangwao
Copy link
Member

yangwao commented Apr 15, 2021

@yangwao yangwao merged commit b496fd9 into kodadot:main Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown render for description text

2 participants