Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 15, 2022

It will now show avaibleBalance in Teleport/Transfer/CreateCollection

PR type

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: f6fb33e

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/620cc7eda28984000939445d

😎 Browse the preview: https://deploy-preview-2362--koda-nuxt.netlify.app

@roiLeo roiLeo changed the title Fix/account/balance ⚒️ account avaible balance Feb 15, 2022
@roiLeo roiLeo requested a review from vikiival February 15, 2022 13:14
@chandradot99
Copy link
Contributor

@roiLeo you have done some changes in this PR which also needs to be changed in #2292 , should I merge your changes into mine or should I wait for this PR to get merged and then add new changes accordingly.

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 16, 2022

@roiLeo you have done some changes in this PR which also needs to be changed in #2292 , should I merge your changes into mine or should I wait for this PR to get merged and then add new changes accordingly.

I'd rather wait for the review this could introduce some breaking change

Comment on lines +21 to +22
const { availableBalance } = await api.derive.balances.all(accountId)
return availableBalance.toString()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { availableBalance } = await api.derive.balances.all(accountId)
return availableBalance.toString()
const { freeBalance } = await api.derive.balances.all(accountId)
return freeBalance.toString()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between freeBalance & availableBalance?

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my personal preference but your code is also legit

@vikiival
Copy link
Member

Screenshot 2022-02-16 at 11 39 00

@yangwao
Copy link
Member

yangwao commented Feb 16, 2022

less opinionated code 🥺😅

but yeah free is in this context way profound

@yangwao yangwao merged commit c8533e4 into kodadot:main Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants