fix: call unbound methods with expected scope

[kkukelka]

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• PR closes (JS-0387) Prefer that unbound methods are called with their expected scope #2321
• call unbound methods with expected scope

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
• I've tested PR on mobile and everything seems works
• I found edge cases
• I've written some unit tests 🧪

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: a649c27

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/6206792c08c0650007a39d99

😎 Browse the preview: https://deploy-preview-2334--koda-nuxt.netlify.app

[kkukelka]

just creates new antipattern... deepsource just doesnt get that keyboardEventsMixin is used as a vue mixin. current implementation is actually correct i believe. the args warning is correct though.

[kkukelka]

asked for help on deepsource discord

[yangwao]

That's amazing you've reached out to their Discord! :)

should we wait for a reply?

[kkukelka]

That's amazing you've reached out to their Discord! :)

should we wait for a reply?

yes, please 😄 already talking to a staff member

[kkukelka]

@yangwao
ok i guess we can merge for now and should watch out for next deepsource release

apparently its a legitimate issue with deepsource

[kkukelka]

[yangwao]

🫣

[yangwao]

If we've fixed it, deepsource should not raise alarms about that in future?

[yangwao]

pay 100 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $100 @ 163.64 USD/KSM ~ 0.611 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x8be040272b307e806d807ef64f3f1120c3df0326339bcbb97d30d274e3460939

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[kkukelka]

If we've fixed it, deepsource should not raise alarms about that in future?

there will be 4 warnings left with "unbound method" until deepsource fixes it, as fixing it now would just introduces new antipatterns. (meaning our code is essentially correct, but deepsource doesnt currently account for lifecycle hooks in mixin files 😵‍💫 )