Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring
desc-sorting.mov

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 8678971

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/6204e9b102ca180007fe10f0

😎 Browse the preview: https://deploy-preview-2316--koda-nuxt.netlify.app

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! lgtm

@yangwao
Copy link
Member

yangwao commented Feb 10, 2022

When I click on Price it puts first 4 0.00 as first and then it goes desc.. it's string/bignum issue?

image

Score, unique items and unique collections could not be sorted hmm, I recall @roiLeo was looking on this one?

@kkukelka
Copy link
Member Author

When I click on Price it puts first 4 0.00 as first and then it goes desc.. it's string/bignum issue?

image

Score, unique items and unique collections could not be sorted hmm, I recall @roiLeo was looking on this one?

yes, formatting issue
Screenshot 2022-02-11 at 07 38 16

@kkukelka
Copy link
Member Author

But i believe this is out of scope of this ticket.
Let's pick it up here 👉 #2327

@yangwao
Copy link
Member

yangwao commented Feb 12, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Feb 12, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 166.07 USD/KSM ~ 0.301 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0xbe54ebfdae53542292a6937dbdee880c9382eab554c43ddeba8500288ffa234d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 12, 2022
@yangwao yangwao merged commit 106c7cb into kodadot:main Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

paid pull-request has been paid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust sorting to be descending at first click

3 participants