Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@chandradot99
Copy link
Contributor

@chandradot99 chandradot99 commented Jan 7, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main-nuxt and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 5811664

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61d8567a80550c0008c9209d

😎 Browse the preview: https://deploy-preview-1715--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Jan 7, 2022

Works when I search

image

But doesn't work when I'm coming from previous search

image

and it opens me wrong results on different string
image

Try yourself https://deploy-preview-1715--koda-nuxt.netlify.app/rmrk/gallery?search=kusama

@chandradot99
Copy link
Contributor Author

@yangwao I have fixed the history issue also, can you check once again. If have also tested if from my side. If there is still any issue, can you please send me small video so that I can reproduce it on my side easily.

@yangwao yangwao requested a review from roiLeo January 8, 2022 12:28
@yangwao
Copy link
Member

yangwao commented Jan 8, 2022

@yangwao I have fixed the history issue also, can you check once again. If have also tested if from my side. If there is still any issue, can you please send me small video so that I can reproduce it on my side easily.

Please update PR template and all needed stuff to proceed

@chandradot99
Copy link
Contributor Author

@yangwao I have fixed the history issue also, can you check once again. If have also tested if from my side. If there is still any issue, can you please send me small video so that I can reproduce it on my side easily.

Please update PR template and all needed stuff to proceed

sure @yangwao

@chandradot99 chandradot99 changed the title #1655 Search input suggestion and history seems broken/gone 1655 Fix Search input suggestions and search history Jan 8, 2022
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it's working as excepted

@yangwao
Copy link
Member

yangwao commented Jan 8, 2022

@yangwao yangwao merged commit caed5d2 into kodadot:main-nuxt Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants