Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

@prachi00 prachi00 commented Dec 27, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

Screenshot 2021-12-27 at 8 42 15 PM

@netlify
Copy link

netlify bot commented Dec 27, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 0a87245

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61c9d84c4d518f0007de5fe8

😎 Browse the preview: https://deploy-preview-1616--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

Why when I click manually through Extra -> Settings -> Advanced I've got

image

and when I take same URL
https://deploy-preview-1616--koda-nuxt.netlify.app/settings?tab=advanced

I'll land on
https://deploy-preview-1616--koda-nuxt.netlify.app/settings/?tab=advanced ?

notice that slash there 👀

image

@prachi00
Copy link
Member Author

Why when I click manually through Extra -> Settings -> Advanced I've got

image

and when I take same URL https://deploy-preview-1616--koda-nuxt.netlify.app/settings?tab=advanced

I'll land on https://deploy-preview-1616--koda-nuxt.netlify.app/settings/?tab=advanced ?

notice that slash there 👀

image

@yangwao yeah, I dont think its going to make any difference tho, the extra slash is being added by itself when you reload, pr

Why when I click manually through Extra -> Settings -> Advanced I've got

image

and when I take same URL https://deploy-preview-1616--koda-nuxt.netlify.app/settings?tab=advanced

I'll land on https://deploy-preview-1616--koda-nuxt.netlify.app/settings/?tab=advanced ?

notice that slash there 👀

image

@yangwao not sure why this could be happening, isn't happening on local, is this causing any issues tho?

@yangwao
Copy link
Member

yangwao commented Dec 28, 2021

yeah don't know, let's merge it and see :)

Perfect, I’ve sent the payout
https://kusama.subscan.io/extrinsic/0x768ca844b65f0cb357aff2e370bf536349858e4555397df85171ce74e503a906

Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/

@yangwao yangwao merged commit 732afc7 into kodadot:main-nuxt Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make advanced settings addressable url

2 participants